Skip to content

Conversation

@fadelananda
Copy link
Contributor

Description

This PR introduces support for TopologySpreadConstraints for Kubernetes version >1.18.0 that we can customize to improve pods spread, leading to high availability.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

feat: use standardized with
@fadelananda fadelananda requested review from a team as code owners March 26, 2025 03:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 26, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@jeremy-albuixech jeremy-albuixech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, could you include an example and ensure it renders properly? thanks!

@fadelananda
Copy link
Contributor Author

this looks good, could you include an example and ensure it renders properly? thanks!

Hi @jeremy-albuixech, here is the screenshots of the render that I did locally, I used a custom values.yaml that contains this values

topologySpreadConstraints:
  - labelSelector:
      matchLabels:
        app: test
    maxSkew: 1
    topologyKey: iss.internal/schedule-priority
    whenUnsatisfiable: DoNotSchedule

Rendering with kubernetes version >= 1.18

render  =1 18

Rendering with kubernetes version < 1.18

render  1 18

Copy link
Contributor

@jeremy-albuixech jeremy-albuixech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you for the contribution :)

@jeremy-albuixech jeremy-albuixech merged commit 0711d5b into openfga:main Mar 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants