fix: set document title via Helmet on the not-found route#1670
Merged
arbrandes merged 1 commit intoopenedx:frontend-basefrom Apr 29, 2026
Merged
fix: set document title via Helmet on the not-found route#1670arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes merged 1 commit intoopenedx:frontend-basefrom
Conversation
NotFoundPage was the only authn route child without a <Helmet> block, so /authn/notfound kept whatever title the previous page set. Add the title following the per-page pattern from frontend-base ADR 0015. Refs openedx/frontend-base#250. Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1670 +/- ##
================================================
Coverage ? 92.03%
================================================
Files ? 93
Lines ? 2047
Branches ? 577
================================================
Hits ? 1884
Misses ? 160
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
approved these changes
Apr 29, 2026
|
🎉 This PR is included in version 1.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs openedx/frontend-base#250.
NotFoundPagewas the only route child in authn that didn't render a<Helmet>block, so/authn/notfoundkept whatever document title the previous page had set. This PR closes the gap by adding the same<Helmet>pattern the other authn pages already follow, with a newerror.notfound.page.titlemessage defaulting toPage Not Found | {siteName}.The pattern is set out in frontend-base ADR 0015.
LLM usage notice
Built with assistance from Claude.