README-onie-vm.md: Remove duplicate step#1107
Open
cpackham-atlnz wants to merge 1 commit intoopencomputeproject:masterfrom
Open
README-onie-vm.md: Remove duplicate step#1107cpackham-atlnz wants to merge 1 commit intoopencomputeproject:masterfrom
cpackham-atlnz wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
The build steps for generating the kvm_x86_64 images had a duplicated step for generating and copying the keys. As `make MACHINE=kvm_x86_64 signing-keys-generate` puts the keys in the required place the copying step was redundant. Remove it and renumber the remaining steps. Signed-off-by: Chris Packham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build steps for generating the kvm_x86_64 images had a duplicated step for generating and copying the keys. As
make MACHINE=kvm_x86_64 signing-keys-generateputs the keys in the required place the copying step was redundant. Remove it and renumber the remaining steps.