Open
Conversation
jloutsenhizer
requested changes
Oct 5, 2023
Contributor
jloutsenhizer
left a comment
jloutsenhizer
left a comment
There was a problem hiding this comment.
Overall I think this is a good change, once the erroneous ID is mapped to the correct ID in via a sameAs alias
| ocd-division/country:us/state:vt/sldu:essex-orleans,Vermont Essex-Orleans State Senate district,,,2023-01-03,,sldu-50E-O,sldu-50E-O,vt-upper-essex-orleans,,,, | ||
| ocd-division/country:us/state:vt/sldu:franklin,Vermont Franklin State Senate district,,,,,sldu-50FRA,sldu-50FRA,vt-upper-franklin,,,, | ||
| ocd-division/country:us/state:vt/sldu:grand_isle,Vermont Grand Isle State Senate district (obsolete),,,,,sldu-50CGI,,,,,, | ||
| ocd-division/country:us/state:vt/sldu:grand_isle-chittenden,Vermont Grand-Isle-Chittenden State Senate district,,,,,,sldu-50CGI,vt-upper-grand-isle-chittenden,,,, |
Contributor
There was a problem hiding this comment.
Instead of completely deleting ocd-division/country:us/state:vt/sldu:grand_isle-chittenden, it should be added to aliases.csv to mark that it is the same-as ocd-division/country:us/state:vt/sldu:grand_isle since some systems might already be using it and relying on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Vermont State Senate district "Grand Isle" erroneously being marked as obsolete, and the non-existent "Grand Isle-Chittenden" (which is actually a lower house district) existing in its place.
According to state reapportionment records this district has been named "Grand Isle" since at least 2002; Chittenden is a separate district (or three districts, as of 2022).