Add top level, state level, and district level OCD-IDs for the Czech Republic#216
Open
ckaminer wants to merge 2 commits intoopencivicdata:masterfrom
Open
Add top level, state level, and district level OCD-IDs for the Czech Republic#216ckaminer wants to merge 2 commits intoopencivicdata:masterfrom
ckaminer wants to merge 2 commits intoopencivicdata:masterfrom
Conversation
Contributor
|
Could you add a README that defines the types and the standards you used when creating the identifiers ? |
rename states file to regions
Contributor
Author
All set 👍 |
azuser
reviewed
Dec 22, 2020
Contributor
azuser
left a comment
azuser
left a comment
There was a problem hiding this comment.
Can you precise the reference you used to generate the ids. When I check Wikipedia https://en.wikipedia.org/wiki/ISO_3166-2:CZ, the ISO ids are numbers.
@jloutsenhizer WDYT ?
| @@ -0,0 +1,15 @@ | |||
| id,name | |||
Contributor
There was a problem hiding this comment.
Can you please order this file?
Contributor
Author
There was a problem hiding this comment.
What do you mean by order?
Contributor
There was a problem hiding this comment.
I meant alphabetical order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.