Add ocd's for last France elections and existing parliament#187
Add ocd's for last France elections and existing parliament#187sguenther85 wants to merge 14 commits intoopencivicdata:masterfrom sguenther85:feature/country-fr
Conversation
|
Looks good. Please add a README briefly explaining what each type is and the source of the sub-country abbreviations (e.g., is there a page listing canonical abbreviations for departments). |
|
Done |
identifiers/country-fr.csv
Outdated
| @@ -0,0 +1,699 @@ | |||
| id,name | |||
| ocd-division/country:fr,France | |||
| ocd-division/country:fr/oversea_department:francais_etablis_hors_de_france,Français établis hors de France | |||
identifiers/country-fr.csv
Outdated
| id,name | ||
| ocd-division/country:fr,France | ||
| ocd-division/country:fr/oversea_department:francais_etablis_hors_de_france,Français établis hors de France | ||
| ocd-division/country:fr/oversea_department:francais_etablis_hors_de_france/ed:1,Première circonscription des Français établis hors de France |
There was a problem hiding this comment.
Didn't we start using the special id diaspora in other PRs? I'd prefer that consistency, instead of francais_etablis_hors_de_france.
There was a problem hiding this comment.
sounds reasonable, is implemented
oversea_department->overseas_department
oversea_department->overseas_department
oversea_department->overseas_department
diaspora
diaspora
oversea_department->overseas_department
diaspora
|
@jdmgoogle @jloutsenhizer Looks good to me. I have no domain expertise for French constituencies though. |
|
Is there still any blocker here? @jdmgoogle @jloutsenhizer |
|
Sorry for the delay in responding. My only concern is if the constituency OCD IDs align with what's being discussed in #188, where we are trending toward having the hierarchy reflect the level of government which administers the constituencies. My brief research led me to this wikipedia article about the 2010 redistricting, but it's unclear to me if the Department governments are in charge of determining the districting or if the national government has some say in this. Do you have any insight on this @sguenther85? |
|
@jloutsenhizer The department government will be only in charge vor local election and smaller constituencies, which are included in the one constituency which is relevant for a national election. Does that help? |
jloutsenhizer
left a comment
jloutsenhizer
left a comment
There was a problem hiding this comment.
Thanks I think that makes sense. I think for this then the hierarchy for National Assmebly constituencies should be removed. I've left a specific comment for an example in the consituencies.csv file.
| @@ -0,0 +1,578 @@ | |||
| id,name | |||
| ocd-division/country:fr/region:ar/department:ai/ed:1,Première circonscription de l'Ain | |||
There was a problem hiding this comment.
To keep in-line with the recent discussions, we should remove the extra nesting. So this OCD ID would become something like
ocd-division/country:fr/ed:ar-ai-1
What do you think?
There was a problem hiding this comment.
Sorry for the long break, but you know ;) UK Elections
Actually a good idea. But of course it could be that we might run into a problem at some point, should there be 'statelists', like in Austria, Germany or Hungary, where there are national, state and constituency lists.
So I would suggest to leave them in if the construct is not fundamentally wrong?
What do you think?
There was a problem hiding this comment.
I'm not sure what you mean by "statelists", could you elaborate?
If you're talking about where different level of governments have different sets of consituencies I think we would have something like:
Country level (taking another look, I think department abbreviations are unique across all departments): ocd-division/country:fr/ed:ai-1
region-level: ocd-division/country:fr/region:ar/red:ai-1
department-level ocd-division/coutnry:fr/region:ar/district:ai/sed:1
Thoughts?
4 participants
No description provided.