app-server: fix outgoing sender test setup#20258
Merged
Conversation
owenlin0
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#17088 changed
OutgoingMessageSender::newto require anAnalyticsEventsClient, but onecommand_exectest added earlier onmainstill called the old one-argument constructor. That leaves currentmainfailing to compile in Bazel and argument-comment-lint jobs.What changed
AnalyticsEventsClient::disabled()to the missedOutgoingMessageSender::newtest call site incommand_exec.rs.Verification
cargo test -p codex-app-server timeout_or_cancellation_reports_cancellation_without_timeout_exit_code