Conversation
Contributor
|
Note Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
#[async_trait] and #[allow(async_fn_in_trait)]
aibrahim-oai
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We have run into two avoidable problems when introducing async trait APIs in Rust:
#[async_trait]has caused materially worse build times in this repository.#[allow(async_fn_in_trait)]makes it too easy to ship a public trait without spelling out whether the returned future isSend, which hides an important part of the trait contract.We already have a good example of the preferred alternative in #16630 /
3c7f013f9735, but that guidance currently lives only as prior art in the codebase. This PR documents the rule inAGENTS.mdso contributors are more likely to follow the native RPITIT pattern before these two shortcuts spread further.What Changed
AGENTS.mddiscouraging both#[async_trait]and#[allow(async_fn_in_trait)]Sendbounds on the returned futureasync fnwhen they satisfy that trait contractVerification