TUI: Remove core protocol dependency [5/7]#20176
Open
etraut-openai wants to merge 1 commit intoetraut/tui-cleanup-4from
Open
TUI: Remove core protocol dependency [5/7]#20176etraut-openai wants to merge 1 commit intoetraut/tui-cleanup-4from
etraut-openai wants to merge 1 commit intoetraut/tui-cleanup-4from
Conversation
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
66a222a to
531dadd
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
84b04c5 to
37aa43d
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
531dadd to
101a3b5
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
37aa43d to
f7a0c57
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
2 times, most recently
from
4402716 to
92d5f01
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
f7a0c57 to
bac74ca
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
92d5f01 to
5564c07
Compare
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 29, 2026
- anomalyco/opencode#24933 merge-after-nits: --file MIME detection fix - anomalyco/opencode#24935 request-changes: in-tree pet+CAVA bundle, ship as plugin only - openai/codex#20176 merge-after-nits: SessionSource via JSON deserialize is brittle - openai/codex#20178 merge-as-is: 1714-line obsolete adapter deletion
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
5564c07 to
e7e2235
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
0a386c5 to
db61a86
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
e7e2235 to
d41547b
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
2 times, most recently
from
d1caffa to
75ba560
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
d41547b to
1ad51fd
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
75ba560 to
00dad84
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
2 times, most recently
from
58a6d02 to
2a06279
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-4
branch
from
00dad84 to
b797a89
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-5
branch
from
2a06279 to
61995e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is part 5 of a 7-PR stack to remove direct
codex_protocol::protocolusage fromcodex-tuiwhile keeping each layer reviewable and shippable.After the main migration, onboarding had one isolated session-source display reference still using the core protocol namespace.
What changed
SessionSourceequivalent.Verification
cargo check -p codex-tui