Skip to content

Comments

refactor to create scene bounding box taking into account of nav graphs too#1072

Merged
aaronchongth merged 3 commits intomainfrom
fix/bounding-box-show-nav-graphs-too
Nov 18, 2025
Merged

refactor to create scene bounding box taking into account of nav graphs too#1072
aaronchongth merged 3 commits intomainfrom
fix/bounding-box-show-nav-graphs-too

Conversation

@aaronchongth
Copy link
Member

What's new

Fixes #1071

  • use both walls and navigation graphs to calculate scene bounding box
  • push alert if scene bounding box is invalid, due to invalid/missing walls or navigation graphs in building map

Before, it used to just render a blank map without errors or indications,
image

Now, without walls but with navigation graphs, it will still be rendered as the boundary also uses nav graphs for calculation,
Screenshot From 2025-11-17 15-06-07

If neither walls or navigation graphs are present, an error alert is pushed,
Screenshot From 2025-11-17 15-06-20

Testing

Start a building map server with a map without walls, for example https://github.com/open-rmf/rmf_demos/blob/ac/test-map-with-no-walls/rmf_demos_maps/maps/office/office.building.yaml, where I just removed the walls. This can be done similarly with the lanes to remove the graphs.

ros2 run rmf_building_map_tools building_map_server <PATH_TO_MODIFIED>/office.building,yaml

Start API server and dashboard per normal.

Self-checks

  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

…hs too

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.02%. Comparing base (88916c7) to head (a2ac224).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rmf-dashboard-framework/src/components/map/map.tsx 52.94% 8 Missing ⚠️
...mf-dashboard-framework/src/components/map/utils.ts 45.45% 6 Missing ⚠️
...hboard-framework/src/components/map/wall-maker.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   69.83%   70.02%   +0.18%     
==========================================
  Files         288      288              
  Lines       14173    14173              
  Branches     1134     1134              
==========================================
+ Hits         9898     9924      +26     
+ Misses       4251     4225      -26     
  Partials       24       24              
Flag Coverage Δ
rmf-dashboard-framework 67.43% <46.66%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronchongth aaronchongth moved this from Inbox to In Review in PMC Board Nov 18, 2025
@aaronchongth
Copy link
Member Author

Consider falling back to just viewing the floorplan of the level if no nvgraph and no walls

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit f33e755 into main Nov 18, 2025
3 checks passed
@aaronchongth aaronchongth deleted the fix/bounding-box-show-nav-graphs-too branch November 18, 2025 04:30
@github-project-automation github-project-automation bot moved this from In Review to Done in PMC Board Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Dashboard should report that building map has no walls instead of silently not rendering anything

2 participants