refactor to create scene bounding box taking into account of nav graphs too#1072
Merged
aaronchongth merged 3 commits intomainfrom Nov 18, 2025
Merged
refactor to create scene bounding box taking into account of nav graphs too#1072aaronchongth merged 3 commits intomainfrom
aaronchongth merged 3 commits intomainfrom
Conversation
…hs too Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 69.83% 70.02% +0.18%
==========================================
Files 288 288
Lines 14173 14173
Branches 1134 1134
==========================================
+ Hits 9898 9924 +26
+ Misses 4251 4225 -26
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Consider falling back to just viewing the floorplan of the level if no nvgraph and no walls |
koonpeng
approved these changes
Nov 18, 2025
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Fixes #1071
Before, it used to just render a blank map without errors or indications,

Now, without walls but with navigation graphs, it will still be rendered as the boundary also uses nav graphs for calculation,

If neither walls or navigation graphs are present, an error alert is pushed,

Testing
Start a building map server with a map without walls, for example https://github.com/open-rmf/rmf_demos/blob/ac/test-map-with-no-walls/rmf_demos_maps/maps/office/office.building.yaml, where I just removed the walls. This can be done similarly with the lanes to remove the graphs.
Start API server and dashboard per normal.
Self-checks
Discussion