Forum Posts feed: Add forum discussion start time check#281
Open
aneno-m-e wants to merge 1 commit intoopen-lms-open-source:MOODLE_401_STABLEfrom
Open
Forum Posts feed: Add forum discussion start time check#281aneno-m-e wants to merge 1 commit intoopen-lms-open-source:MOODLE_401_STABLEfrom
aneno-m-e wants to merge 1 commit intoopen-lms-open-source:MOODLE_401_STABLEfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussions with a start time in the future are visible in the 'Forum Posts' feed on the 'My Courses' page. When a student clicks on the discussion title, they are presented with an error message, which is expected as the discussion is not yet available but not ideal as a user experience.
This PR adds a WHERE clause checking that the discussion timestart is in the past, thus preventing the posts from showing in the feed if the start time has not yet been reached.