all: reenable lint rules after Angular 19 upgrade (connects #9082)

[paulbert]

Some lint rules were disabled after the upgrade to Angular 19. Reenabling them here. See https://github.com/open-learning-exchange/planet/pull/9754/changes#diff-6884918dc8291219be508e05e28965b958c734def85324f3b53858ea4702090f for the disabled rules.

Note that for the quotes rule { "allowTemplateLiterals": "never" } still allows template literals. It actually throws an error when backticks are used without a template literal or with a one line string.

[paulbert]

All of them are reenabled now except for no-host-metadata-property which we should consider a different approach since the Angular team's recommendation is now to prefer host metadata properties.

See https://github.com/angular-eslint/angular-eslint/blob/v18.4.3/packages/eslint-plugin/docs/rules/no-host-metadata-property.md and angular/angular#52561

[paulbert]

Note this also upgrades ESLint to v9. typescript-eslint v8 supports ESLint v9 https://typescript-eslint.io/blog/announcing-typescript-eslint-v8

[Mutugiii]

Running into this error when I run ng lint

[paulbert]

Running into this error when I run ng lint

Sorry I forgot to point out you'll need to run an npm install to install the stylistic plugin.

[Mutugiii]

Running into this error when I run ng lint

Sorry I forgot to point out you'll need to run an npm install to install the stylistic plugin.

This is after removing the package-lock.json, running npm install & running the linting commands

[paulbert]

Figured out it's not working in Node 18 vs 20, but it could also be fixed by changing to the new default config format for ESLint v9. See https://eslint.org/docs/latest/use/migrate-to-9.0.0#-new-default-config-format-eslintconfigjs

[paulbert]

@Mutugiii Upgraded the config file for ESLint and it appears to be working with Node 18 now.

Keeping the old file because the commented out rules did not make it into the new file.

[paulbert]

I'm converting this to a draft because the latest change broke the linting for chatapi.

[paulbert]

Jules came up with a much simpler fix, ready for review now @Mutugiii