Skip to content

Remove Dec 2024/Jan 2025 challengePeriod branches#9801

Draft
Saby-Bishops wants to merge 1 commit intomasterfrom
codex/remove-challengeperiod-and-related-logic
Draft

Remove Dec 2024/Jan 2025 challengePeriod branches#9801
Saby-Bishops wants to merge 1 commit intomasterfrom
codex/remove-challengeperiod-and-related-logic

Conversation

@Saby-Bishops
Copy link
Copy Markdown
Member

Motivation

  • The Dec 2024 / Jan 2025 time-gated campaign is being retired, so the date-gated challengePeriod checks and related UI flows should be removed.

Description

  • Removed the exported challengePeriod constant from src/app/shared/dialogs/dialogs-announcement.component.ts so the date gate no longer exists.
  • Removed conditional branches that opened the announcement dialog when the campaign was active from courses-step-view.component.ts, exams-view.component.ts, home.component.ts, and notifications.component.ts and simplified openAnnouncementDialog to stop trying to open the campaign dialog.
  • Deleted the automatic community startup campaign flow (communityChallenge) and its invocation in community.component.ts, and removed the campaign notification sender that only ran under the date-gated branch.
  • Cleaned up imports/usages of the announcement dialog where it was only referenced for the expired campaign check so the code no longer depends on challengePeriod at those call sites.

Testing

  • Ran npm run -s lint in the environment; it failed due to missing Angular CLI (ng: not found), so lint could not be validated here (failed).
  • Ran TypeScript compile check npx tsc -p tsconfig.json --noEmit; it failed because project dependencies (Angular packages / tslib) are not installed in this environment, so a full type-check could not complete (failed).

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant