Remove Dec 2024/Jan 2025 challengePeriod branches#9801
Draft
Saby-Bishops wants to merge 1 commit intomasterfrom
Draft
Remove Dec 2024/Jan 2025 challengePeriod branches#9801Saby-Bishops wants to merge 1 commit intomasterfrom
Saby-Bishops wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
challengePeriodchecks and related UI flows should be removed.Description
challengePeriodconstant fromsrc/app/shared/dialogs/dialogs-announcement.component.tsso the date gate no longer exists.courses-step-view.component.ts,exams-view.component.ts,home.component.ts, andnotifications.component.tsand simplifiedopenAnnouncementDialogto stop trying to open the campaign dialog.communityChallenge) and its invocation incommunity.component.ts, and removed the campaign notification sender that only ran under the date-gated branch.challengePeriodat those call sites.Testing
npm run -s lintin the environment; it failed due to missing Angular CLI (ng: not found), so lint could not be validated here (failed).npx tsc -p tsconfig.json --noEmit; it failed because project dependencies (Angular packages /tslib) are not installed in this environment, so a full type-check could not complete (failed).Codex Task