Export shared member name comparator and use it in team chat sharing#9799
Draft
Saby-Bishops wants to merge 1 commit intomasterfrom
Draft
Export shared member name comparator and use it in team chat sharing#9799Saby-Bishops wants to merge 1 commit intomasterfrom
Saby-Bishops wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
userDocis missing or partial.Description
src/app/teams/teams.utils.tsasmemberSortNameandmemberNameComparewith a brief docstring describing intended external usage.userDoc.doc.lastName,userDoc.lastName,userDoc.fullName,name, and finallyuserIdwhen available.memberNameCompareinsrc/app/shared/dialogs/dialogs-chat-share.component.tsto sort membership recipients before sending notifications.src/app/shared/dialogs/dialogs-chat-share.component.spec.tsthat assert membership filtering and stable name sorting whenuserDocis missing.Testing
src/app/shared/dialogs/dialogs-chat-share.component.spec.tscovering membership filtering and name-sorting behavior (tests present in the tree).npm run test/npx ng testfor the single spec, but automated test execution failed in this environment due to missing Angular CLI (ng: not found/ CLI executable unavailable).Codex Task