Open
Conversation
31db1ca to
ae916ad
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OS Image Composer’s template and RPM package-resolution capabilities to support wildcard package patterns and repo-priority–based candidate selection, while also updating several PTL-related Ubuntu/EMT templates to include additional packages and repository pinning updates.
Changes:
- Add glob/wildcard support for RPM package filtering and requested package expansion, with additional resolver test coverage.
- Introduce repository-priority–aware selection for multi-candidate RPM dependency resolution.
- Update the image template JSON schema and example templates to use
allowPackagesand permit glob patterns in package lists.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/ospackage/rpmutils/resolver_test.go | Adds unit tests for glob matching in package filters and wildcard request expansion. |
| internal/ospackage/rpmutils/resolver.go | Implements glob matching in package filtering and expands MatchRequested to support wildcards with de-duping. |
| internal/ospackage/rpmutils/helper_test.go | Extends tests for wildcard matching and adds repo-priority scenarios for multi-candidate resolution. |
| internal/ospackage/rpmutils/helper.go | Adds repo-priority selection logic plus wildcard request matching helpers and wildcard expansion. |
| internal/config/validate/validate_test.go | Adds schema-validation tests for wildcard packages and malformed allowPackages entries. |
| internal/config/schema/os-image-template.schema.json | Permits glob patterns in systemConfig.packages and allowPackages, and renames schema key to allowPackages. |
| internal/config/config.go | Renames YAML tag to allowPackages for PackageRepository.AllowPackages. |
| image-templates/ubuntu24-x86_64-minimal-ptl.yml | Adds a small set of additional packages to the PTL Ubuntu 24 template. |
| image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml | Adds the same additional packages to the PTL Ubuntu 24 DLS template. |
| image-templates/rcd10-x86_64-dlstreamer.yml | Updates repo pinning key name to allowPackages. |
| image-templates/emt3-x86_64-ptl-emf-rt-raw.yml | Expands repo allowlist/packages, adds disk layout changes, and uses wildcard allowPackages entries. |
| image-templates/emt3-x86_64-ptl-emf-raw.yml | Similar EMT PTL template expansion with repo priority and wildcard allowPackages entries. |
yockgen
approved these changes
Feb 26, 2026
… template document
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Any Newly Introduced Dependencies
How Has This Been Tested?