Skip to content

fix: non vector db tasks#8849

Merged
evan-onyx merged 3 commits intomainfrom
feat/no-bg-container2
Feb 28, 2026
Merged

fix: non vector db tasks#8849
evan-onyx merged 3 commits intomainfrom
feat/no-bg-container2

Conversation

@evan-onyx
Copy link
Contributor

@evan-onyx evan-onyx commented Feb 27, 2026

Description

update list of non vector db tasks and make redis-based locking optional based on task args

How Has This Been Tested?

n/a

Additional Options

  • [Optional] Please cherry-pick this PR to the latest release version.
  • [Optional] Override Linear Check

Summary by cubic

Update the non-vector DB Celery schedule to run migrate-chunks-from-vespa-to-opensearch and remove deprecated document-migration tasks when DISABLE_VECTOR_DB is enabled. Refactor user-file process/delete/project-sync into shared _impl functions with an optional redis_locking flag (Celery=True, background=False), tighten typing and lock handling, and add unit tests for lock behavior, queued-key clearing, and consistent DB logic without Redis.

Written for commit 2eae82a. Summary will update on new commits.

@evan-onyx evan-onyx requested a review from a team as a code owner February 27, 2026 03:04
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR cleans up the _VECTOR_DB_BEAT_TASK_NAMES set by removing two deprecated task names (check-for-documents-for-opensearch-migration and migrate-documents-from-vespa-to-opensearch) and adding the current task name (migrate-chunks-from-vespa-to-opensearch).

Changes:

  • Removed obsolete task names that were already removed from the actual beat task templates in previous changes
  • Added migrate-chunks-from-vespa-to-opensearch which is the actual task defined when ENABLE_OPENSEARCH_INDEXING_FOR_ONYX is enabled
  • Ensures the filtering logic for DISABLE_VECTOR_DB works correctly with the current set of tasks

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Simple cleanup that removes stale task names from a set and adds the correct current task name. The change is straightforward, well-scoped, and maintains consistency between the task definitions and the vector DB task list.
  • No files require special attention

Important Files Changed

Filename Overview
backend/onyx/background/celery/tasks/beat_schedule.py Updated _VECTOR_DB_BEAT_TASK_NAMES set to remove deprecated task names and add current migration task - ensures consistency with actual task definitions

Last reviewed commit: b553828

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Base automatically changed from feat/no-bg-container1 to main February 28, 2026 03:01
@evan-onyx evan-onyx force-pushed the feat/no-bg-container2 branch from 4912dd7 to 6a2d7ab Compare February 28, 2026 03:08
@evan-onyx evan-onyx enabled auto-merge February 28, 2026 03:09
@github-actions
Copy link
Contributor

Preview Deployment

Status Preview Commit Updated
https://onyx-preview-2xu2t19zx-danswer.vercel.app 6a2d7ab 2026-02-28 03:11:39 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

🖼️ Visual Regression Report

Project Changed Added Removed Unchanged Report
admin 38 0 0 71 View Report
exclusive 0 0 0 8 ✅ No changes

@evan-onyx evan-onyx added this pull request to the merge queue Feb 28, 2026
Merged via the queue into main with commit 7f9e374 Feb 28, 2026
86 checks passed
@evan-onyx evan-onyx deleted the feat/no-bg-container2 branch February 28, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants