1137 move ios android all source code to monorepo#1138
Conversation
feat: log callback to native
* fix: key is not on the server. * feat: optimize code
1627 - fix: bubble item
305 - feat: payer interceptor modal for surge pricing
feat: display all profile in send account list
feat: add flow network interceptor
* feat: replace bridge fee and payer signer endpoint * feat: update endpoint signAsBridgeFeePayer * feat: update endpoint call
* feat: show alert * feat: update main.jsbundle * feat: surge price alert * feat: update endpoint response struct
feat: surge pricing
* feat: amount only use maxfee * feat: show surge alert on Authz
feat: add key search on Secure Enclave Key
fix: surge pricing alert
* fix: replace with user payer address and keyid * feat: walletconnect add authz surge alert
fix: transaction and coa connect
fix: native bridge implementation
Adding SAST-SCA
…-for-onboarding-workflow 310/972 ios create native bridge for onboarding workflow
* fix: logout issue when key is available but no profile * Bump version 3.0.11 * feat: revert podfile.lock * feat: replace coinbase url (#1989) --------- Co-authored-by: lmcmz <lmcmze@gmail.com>
PR SummaryMigrated the Android source code from a Git submodule to be directly included in the monorepo. This change removes the Changes
autogenerated by presubmit.ai |
Dependency ReviewThe following issues were found:
|
|
This pull request introduces dependencies with security vulnerabilities of moderate severity or higher. Vulnerable Dependencies:📦 aws-sdk-s3@1.183.0 What to do next?
Security Engineering contact: #security on slack |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (30)
-
fix: replace with user payer address and keyid
-
feat: walletconnect add authz surge alert
- c42a7e0: Merge pull request #1986 from onflow/surge_pricing
fix: surge pricing alert
feat: add key search on Secure Enclave Key
-
feat: amount only use maxfee
-
feat: show surge alert on Authz
feat: surge pricing
- 31d33a7: feat: surge pricing
- 15a2c5b: feat: udpate request for pay endpoint (#1846)
- b07c2bf: Feat/surge alert 300 (#1845)
-
feat: show alert
-
feat: update main.jsbundle
-
feat: surge price alert
-
feat: update endpoint response struct
- a38ded9: Feat/553 ios update bridge fee and payer signer endpoint (#1839)
-
feat: replace bridge fee and payer signer endpoint
-
feat: update endpoint signAsBridgeFeePayer
-
feat: update endpoint call
- 9106a58: Update incorrect endpoint (#1838)
- 52b0f70: Merge pull request #1808 from onflow/300-surge-price-horizontal-handle
feat: add flow network interceptor
- b06892b: Merge pull request #1938 from onflow/display_all_profile
feat: display all profile in send account list
- 079092f: feat: display all profile in send account list
- 7c2d2c5: Merge pull request #1821 from onflow/305-android-surge-payer-interceptor
305 - feat: payer interceptor modal for surge pricing
- 34d6436: Merge branch 'dev' into 300-surge-price-horizontal-handle
- ad303e4: feat: surge price handling browser & walletconnect
- 3c162fc: Merge pull request #1926 from onflow/1627-bubble-item
1627 - fix: bubble item
-
fix: key is not on the server.
-
feat: optimize code
- 0a8b486: fix: bubble item
- 360b815: fix: bubble item
- bde1c42: feat: add
logToNativebridge (#1830) - d6a0825: Merge pull request #1915 from onflow/log_bridge
feat: log callback to native
Files Processed (30)
- .gitignore (1 hunk)
- .gitmodules (1 hunk)
- apps/react-native/android (1 hunk)
- apps/react-native/android/.github/CODEOWNERS (1 hunk)
- apps/react-native/android/.github/ISSUE_TEMPLATE/bug_report.yml (1 hunk)
- apps/react-native/android/.github/ISSUE_TEMPLATE/feature_request.yml (1 hunk)
- apps/react-native/android/.github/pull_request_template.md (1 hunk)
- apps/react-native/android/.github/workflows/check-linked-issues.yml (1 hunk)
- apps/react-native/android/.github/workflows/migrate-secrets.yml (1 hunk)
- apps/react-native/android/.github/workflows/presubmit.yml (1 hunk)
- apps/react-native/android/.github/workflows/release.yml (1 hunk)
- apps/react-native/android/.gitignore (1 hunk)
- apps/react-native/android/.gitmodules (0 hunks)
- apps/react-native/android/.kotlin/errors/errors-1756419679881.log (1 hunk)
- apps/react-native/android/.kotlin/errors/errors-1756427853679.log (1 hunk)
- apps/react-native/android/Gemfile (1 hunk)
- apps/react-native/android/Gemfile.lock (1 hunk)
- apps/react-native/android/LICENSE.md (1 hunk)
- apps/react-native/android/README.md (1 hunk)
- apps/react-native/android/app/.gitignore (1 hunk)
- apps/react-native/android/app/build.gradle (1 hunk)
- apps/react-native/android/app/libs/trustwalletcore.aar (0 hunks)
- apps/react-native/android/app/proguard-rules.pro (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestAES.kt (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestApi.kt (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestFlowTransaction.kt (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestKeyStore.kt (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestWallet.kt (1 hunk)
- apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/manager/key/KeyCompatibilityManagerSimpleTest.kt (1 hunk)
- apps/react-native/android/app/src/assetlinks.json (1 hunk)
Actionable Comments (1)
-
apps/react-native/android/.github/workflows/presubmit.yml [1-1]
possible bug: "Malformed YAML workflow name."
Skipped Comments (6)
-
apps/react-native/android/.kotlin/errors/errors-1756419679881.log [1-154]
best practice: "Build error logs should not be committed to the repository."
-
apps/react-native/android/.kotlin/errors/errors-1756427853679.log [1-33]
best practice: "Build error logs should not be committed to the repository."
-
apps/react-native/android/.github/workflows/check-linked-issues.yml [20-20]
best practice: "Missing newline at end of file."
-
apps/react-native/android/app/build.gradle [44-46]
security: "Hardcoded username in build configuration."
-
apps/react-native/android/.gitmodules [1-1]
maintainability: "Empty gitmodules file should be removed."
-
apps/react-native/android/app/src/androidTest/java/com/flowfoundation/wallet/TestKeyStore.kt [97-100]
possible bug: "Potential null pointer exception in test."
| @@ -0,0 +1,28 @@ | |||
| claude-sonnet-4-5-20250929name: Presubmit.ai | |||
There was a problem hiding this comment.
The first line appears to have a malformed workflow name. It starts with claude-sonnet-4-5-20250929name: instead of just name:. This will cause the workflow to fail to parse correctly.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 36817e9: update payer request data model
Files Processed (1)
- .gitignore (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
.gitignore [50-51]
maintainability: "Comment is now misleading after removing ios and android entries."
🔗 Related Issues
Closes #1137
Linked automatically from the branch name. If incorrect, edit:
Self-Checklist
📝 Description
📸 Screenshots/Videos