896 - Register v4 #2314
Merged
896 - Register v4 #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmcmz
requested changes
Dec 12, 2025
app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt
Outdated
Show resolved
Hide resolved
...n/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
lmcmz
reviewed
Dec 12, 2025
...n/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt
Outdated
Show resolved
Hide resolved
lealobanov
force-pushed
the
register-v4
branch
from
588d1d4 to
9dfeef1
Compare
lealobanov
force-pushed
the
register-v4
branch
from
40bdf69 to
23043fe
Compare
jaymengxy
approved these changes
Jan 7, 2026
lmcmz
reviewed
Jan 7, 2026
| logd(TAG, "Stored mnemonic globally for backup support") | ||
|
|
||
| // Create a new private key | ||
| val privateKey = PrivateKey.create(storage) |
Contributor
There was a problem hiding this comment.
@lealobanov Why we create this private key in here ? We already create the mnemonic before.
Contributor
There was a problem hiding this comment.
Ohh I remember it now, this register func need rewrite
onflow/FRW-monorepo#1085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)