Remove ensureIndex from MongoLock constructor.#3
Open
Conversation
|
|
||
| foreach ($this->collection->getIndexInfo() as $index) { | ||
| if ($index['name'] === 'program_unique') { | ||
| $present = true; |
Contributor
There was a problem hiding this comment.
break
or better extract method and use return
razielgn
force-pushed
the
remove-ensure-index-from-mongo-lock-constructor
branch
from
879818a to
ec0df9e
Compare
Contributor
|
👍 |
razielgn
force-pushed
the
remove-ensure-index-from-mongo-lock-constructor
branch
from
ec0df9e to
772ac60
Compare
… detecting when it's missing.
razielgn
force-pushed
the
remove-ensure-index-from-mongo-lock-constructor
branch
from
772ac60 to
5678867
Compare
Contributor
|
Doing the job that should have been done by the driver's since 1942 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes major issues when the lock is written to a replicaSet: somehow it puts a great deal of pressure on it.
This patch removes the
ensureIndexthat keeps banging at a primary's door, while still checking wether the index (which is vital) is present or not before lock acquirement.