Skip to content

Collection of subschema improvements and some general features#473

Closed
perher wants to merge 5 commits intoomissis:mainfrom
perher:dev
Closed

Collection of subschema improvements and some general features#473
perher wants to merge 5 commits intoomissis:mainfrom
perher:dev

Conversation

@perher
Copy link
Contributor

@perher perher commented Aug 29, 2025

This is a large collection of fixes that mostly improves on the subschemas (allOf/anyOf) support added in #99.

Keeping this as one large MR for now to reflect the larger work being done in my fork as this project seems less active nowadays.

New features:

Fixes:

Breaking changes:

  • anyOf could mark properties as required even if they were only required in one of the subschemas

Includes PRs

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 42.99065% with 122 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@37d54f2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/data/core/allOf/allOfWithAnyOf.go 0.00% 66 Missing ⚠️
tests/data/core/allOf/allOfNestedRefs.go 0.00% 48 Missing ⚠️
pkg/generator/schema_generator.go 85.45% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage        ?   41.15%           
=======================================
  Files           ?       68           
  Lines           ?     5849           
  Branches        ?        0           
=======================================
  Hits            ?     2407           
  Misses          ?     3163           
  Partials        ?      279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perher
Copy link
Contributor Author

perher commented Aug 29, 2025

Above are tagged as v0.21.0-beta.0 in https://github.com/perher/go-jsonschema

@omissis
Copy link
Owner

omissis commented Jan 24, 2026

@perher can this PR be closed? #480 and #481 have been merged, and #482 will likely be part of v0.22.0

@perher
Copy link
Contributor Author

perher commented Jan 25, 2026

@perher can this PR be closed? #480 and #481 have been merged, and #482 will likely be part of v0.22.0

Thank you @omissis for following up on this 🙏

I've split the remaining features into separate PRs now for you to review at your convenience #509 #510 #511 #512

So will close this PR.

@perher perher closed this Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants