Merged
Conversation
Member
Author
Member
Author
|
Submitted to Khronos for review here: KhronosGroup/glTF#2137 |
Adjustments to KHR_audio PR recommendations to split audio out
Adjust name of sources.schema and makes new proper sources object schema
Member
|
Where can I find example glTF files that use KHR_audio? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This PR proposes a number of changes discussed during the OMI/Khronos 3D Formats Working Group Meeting on 3/23/2022 with @robertlong, @fire, and @lyuma in attendance.
Khronos is eager to unify the MSFT_audio_emitter and OMI_audio_emitter extensions into a single common KHR extension.
Since
OMI_audio_emitteris effectively a subset of theMSFT_audio_emitterfeatures, there are no additional features to be added toOMI_audio_emitter. Only changes to how the JSON schema is defined, likely some clarifications to the spec in future PRs, and a change in extension name to reflect that this will be the official Khronos ratified extension.Here are the changes to the schema:
OMI_audio_emittertoKHR_audio.KHR_audioboth reflects the intent for this to be an official Khronos ratified extension and a more general audio extension to form the basis for additional extensions to provide features such as audio mixing, animation/one shot triggering of clips, additional audio format support, etc.audioEmitter/audioEmittersproperties have been renamed toemitter/emitters. Theaudioprefix is redundant because these properties are nested underKHR_audiopositionalobject. This object can be added to audio emitters when it is of typepositional.nodesinstead ofemittersWe will discuss these changes in our weekly glTF Working Group meeting tomorrow and decide if we'd like to take this to a vote in the following meeting. If that passes, we'll go forward with submitting this as a PR to the Khronos repository.