Vehicles: Add braking, add change rate, rename current to target#255
Merged
aaronfranke merged 1 commit intomainfrom Feb 9, 2026
Merged
Vehicles: Add braking, add change rate, rename current to target#255aaronfranke merged 1 commit intomainfrom
aaronfranke merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR significantly improves the OMI vehicle extension specifications by renaming properties to better represent their purpose (from current* to target*), adding support for gradual state changes through rate properties, introducing braking force for wheels, and making the linearGimbalAdjustRatio an explicit configurable property. The changes align the specification with implementation experience from the Basis VR and Godot Engine projects.
Key changes include:
- Renamed
current*properties totarget*to clarify these represent desired input values rather than actual states - Added
brakingForce,propulsionForceChangeRate, andsteeringChangeRateproperties to wheels for more realistic vehicle physics - Added
forceChangeRate,gimbalChangeRate,hoverEnergyChangeRate, andlinearGimbalAdjustRatioproperties to thrusters for fine-tuned control - Enhanced schema validation with minimum/maximum constraints and better documentation
- Added comprehensive glTF Object Model sections for runtime property manipulation
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/2.0/OMI_vehicle_wheel/schema/glTF.OMI_vehicle_wheel.wheel.schema.json | Added braking force, rate-of-change properties, renamed force/steering properties to target*, and added schema constraints |
| extensions/2.0/OMI_vehicle_wheel/examples/simple_car.gltf | Updated property name from maxForce to maxPropulsionForce |
| extensions/2.0/OMI_vehicle_wheel/README.md | Updated documentation with new property descriptions, added glTF Object Model section, and updated implementation references |
| extensions/2.0/OMI_vehicle_thruster/schema/glTF.OMI_vehicle_thruster.thruster.schema.json | Added rate-of-change and linearGimbalAdjustRatio properties, renamed to target*, added schema constraints |
| extensions/2.0/OMI_vehicle_thruster/README.md | Reorganized property documentation, added new property descriptions, added glTF Object Model section |
| extensions/2.0/OMI_vehicle_hover_thruster/schema/glTF.OMI_vehicle_hover_thruster.thruster.schema.json | Added rate-of-change and linearGimbalAdjustRatio properties, renamed to target*, added schema constraints |
| extensions/2.0/OMI_vehicle_hover_thruster/examples/hovercraft.gltf | Improved node naming (abbreviated to full descriptive names) and removed empty extensions object |
| extensions/2.0/OMI_vehicle_hover_thruster/README.md | Reorganized property documentation, added new property descriptions, added glTF Object Model section |
| extensions/2.0/OMI_vehicle_body/schema/node.OMI_vehicle_body.schema.json | Clarified description text for maxSpeed and useThrottle properties |
| extensions/2.0/OMI_vehicle_body/README.md | Added glTF Object Model section and updated implementation references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/2.0/OMI_vehicle_hover_thruster/schema/glTF.OMI_vehicle_hover_thruster.thruster.schema.json
Show resolved
Hide resolved
extensions/2.0/OMI_vehicle_thruster/schema/glTF.OMI_vehicle_thruster.thruster.schema.json
Outdated
Show resolved
Hide resolved
extensions/2.0/OMI_vehicle_wheel/schema/glTF.OMI_vehicle_wheel.wheel.schema.json
Show resolved
Hide resolved
cb4dee0 to
80c1fa2
Compare
80c1fa2 to
fda76b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OMI_vehicle_* extension specifications to correspond with the changes I thought about while making the Basis implementation: BasisVR/Basis#442
Specifically, here is a list of most of the changes:
currenttotargetto better represent these as the input values of the parts.linearGimbalAdjustRatioas an explicit property instead of leaving it as an implementation detail.The Godot implementation has been updated to be in sync with this updated specification and the Basis implementation: omigroup/omi-godot#19