KHR_audio_emitter: Rename pitchSpeed to playbackRate and rename autoplay#248
Merged
aaronfranke merged 1 commit intoomigroup:mainfrom Apr 10, 2025
Merged
Conversation
docEdub
approved these changes
Apr 9, 2025
aaronfranke
force-pushed
the
audio-playback-rate
branch
from
1fa6a21 to
d159492
Compare
aaronfranke
changed the title
pitchSpeed to playbackRatepitchSpeed to playbackRate and rename autoplay
yankscally
reviewed
Apr 10, 2025
There was a problem hiding this comment.
discussed in omi gltf meeting:
"autoplay" is defined as one word, another example is is "username" :
https://english.stackexchange.com/a/43440
we can find lowercase spelling of this everywhere:
https://developer.mozilla.org/en-US/docs/Web/Media/Guides/Autoplay#autoplay_and_autoplay_blocking
https://www.w3schools.com/jsref/prop_video_autoplay.asp
(and more)
playbackRate is also matching Web Audio.
yankscally
approved these changes
Apr 10, 2025
yankscally
left a comment
yankscally
left a comment
There was a problem hiding this comment.
welcome changes. read conversation in PR for the full review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this property controls the combined pitch and playback speed, I opened PR #239 with the name
"pitchSpeed". However, this differs from Web Audio, and multiple people have expressed confusion.This PR renames the
"pitchSpeed"to"playbackRate"to match Web Audio. However, I intentionally kept the description the same, but added even more text to clarify that this does not resample and pitch+speed are locked in together.This PR also renames
autoPlaytoautoplaybecause it seems that this is the dominant casing across the industry.