Add "shapeType" property to positional audio emitters#229
Merged
antpb merged 1 commit intoomigroup:mainfrom Aug 1, 2024
Merged
Add "shapeType" property to positional audio emitters#229antpb merged 1 commit intoomigroup:mainfrom
"shapeType" property to positional audio emitters#229antpb merged 1 commit intoomigroup:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KhronosGroup/glTF#2421 (comment)
@cashah from Meta and Khronos suggested an explicit shape type in their KHR_audio_graph proposal is better and more runtime-friendly. It also opens the door to extensions making their own shape type in the future. This PR modifies KHR_audio_emitter to include an explicit
"shapeType"property with the same values.I also updated the sub-headings to be human-friendly words, with the property name in the prose. This is consistent with existing Khronos specs and other OMI specs.
Preview: https://github.com/omigroup/gltf-extensions/tree/main/extensions/2.0/KHR_audio_emitter#shape-type