Added ability to invert Menu Event button logic #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Bumping this PR...Any desire to merge this? Relatively simple addition, but provides some helpful functionality. |
Owner
|
Probably I missed this. But actually it is my goal to remove button functionality. Instead MUI will be there which will support external button libraries: https://github.com/olikraus/u8g2/tree/master/sys/arduino/u8g2_page_buffer/MUIInput2BtnBounce2 MUI: #1747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small enhancement providing the user the ability to invert the logic of buttons used with menu events. This is helpful when a button is active HIGH rather than active LOW like the library currently supports. A simple bool to toggle inverted logic was added to the 'begin()' method when 'U8X8_USE_PINS' is defined.