[IMP] Implement Phase 1 of Go To References (#466) #519

MihaiStreames · 2026-01-15T20:51:36Z

Summary

Implements same-file Go To References for Python files
Adds scope-aware symbol validation to handle variable shadowing
Includes tests for classes, variables, imports, and self parameter

Closes #466 (partially - Phase 1 only)

Future work

See TODOs in server/src/features/references.rs:

Cross-file references within module
Workspace-wide references
Odoo-specific: XML field refs, string-based model refs

fda-odoo

Thank you very much for your pull request, it's a pleasure to see people suggesting new features or functionnalities!

I checked rapidly what you did as this is a "part 1" PR, to be sure you are on the right track!
And indeed it seems really good. I put some comments about things I'm not sure about, but the execution is efficient!

I guess moving to the "part 2" and searching in other files will be more difficult, if you don't want to browse all files. The idea that comes in my mind would be to only execute your algorithm in files that are importing the current file. Because if they do, they maybe use your symbol.
By chance, each file already knows who is importing them, by the "dependents" variable. You'll see that this field is sorting files in function of the depending step:
ARCH, ARCH_EVAL or VALIDATION.
I think (but I can miss something here) that you should only take files in the ARCH (but it would be easy to change if I forget something)

If you have any question, I'll stay available !

fda-odoo · 2026-01-18T15:11:51Z

server/src/features/references.rs

+
+        let (analyse_ast_result, _range, _call_expr) = AstUtils::get_symbols(session, file_symbol, file_info, offset as u32);
+
+        if analyse_ast_result.evaluations.is_empty() {


This test seems wrong, but I don't know what you are trying to prevent.
This 'if' will prevent any variable without evaluation, classes or function to get the 'reference' feature working.

fda-odoo · 2026-01-18T15:16:41Z

server/src/features/references.rs

+            return None;
+        }
+
+        let eval = &analyse_ast_result.evaluations[0];


I think there is a misunderstanding on the meaning of "evaluations".
An evaluation is the different values a variable/function can take (inferred with code or signature).
For example:

a = 5 def test(): return a

the variable "a" will have an evaluation to the value "5" (of type int)
and the function "test" will have an evaluation to "a" (that has the previous evaluation to "5")

Taking the evaluation[0] here would mean that you are trying to find all references to "5" if you do it on "a".

fda-odoo · 2026-01-18T15:22:34Z

server/src/features/references.rs

+            // infer name
+            let match_offset = match_range.start().to_u32();
+            let scope = Symbol::get_scope_symbol(file_symbol.clone(), match_offset, false);
+            AstUtils::build_scope(session, &scope);


That's a nice thing to do here!

CachedModel is not required to define Odoo models, so we should not fail to detect models if CachedModel is not found in the Odoo source code. Treat `Model` and `TransientModel` similarly. only exit if `BaseModel` does not exist.

While validating search domain, for relational fields, i.e. "m2ofield.normalfield", we should check all the symbols m2ofield on the model, not just one, so we set true on get member symbol

We are trying to do that by checking _register = False. The check was failing because we handled only one evaluation. However, in latest versions we also have a type hint, which is its own evaluation. For that, we implement here a smarter search that only looks are evaluations with values. In that case, we should be more generic in catching cases. Consider using this as the check, instead of checking symbol trees

Check if class model is in a module, otherwise do not mark it as a model This is to avoid crashing later due to the class not being in a model. The crash to avoid is in `core.model.Model.get_symbols`

The base model's search method should have an evaluation of EvaluationSymbolPtr::SELF. This used to be the case, but it got lost in a refactor ([1]). [1]: odoo@ca26c3e

Before we were checking if inverse_name arg points to a M2O field, but it can also be a Many2oneReference Fixed false positives for OLS03022

__init_subclass__ and __class_getitem__ have a special behavior where they are implicitly classmethods without the decorator This is added here to avoid, for example, wrong diagnostics

Fix arg index to account for is on instance if it is true

fda-odoo · 2026-01-28T10:10:57Z

@MihaiStreames Hello!
I don't know if you tried to work on the Part 2 already or not, but this feature was planned for the next version 1.3, so if I'll take the development of it from now on. If you have already some work done, do not hesitate to share it, it would be a pleasure to discuss on it.
I'll start from your commit to include it in the final feature !
Thank you again for your input on this!

fda-odoo · 2026-01-28T10:22:05Z

New Pull request: #531

MihaiStreames · 2026-01-28T12:08:04Z

Hey @fda-odoo! Sorry for the late reply, was on vacation and then swamped with exams.

Thanks for the review and for taking this forward! Your comments make total sense:

The evaluations.is_empty() check was too aggressive, you're right it would block classes/functions without evaluations
Good catch on evaluations[0], I see now that gives you the evaluated value rather than the symbol itself. I was treating it like the Definition feature does but didn't fully understand the evaluation semantics

Glad you're building on this for 1.3.0! I don't have any Part 2 work done yet.

Happy to help test or review if useful 👍

[IMP] Implement Phase 1 of Go To References (odoo#466)

1be36bb

fda-odoo self-requested a review January 18, 2026 15:06

fda-odoo added the enhancement New feature or request label Jan 18, 2026

fda-odoo reviewed Jan 18, 2026

View reviewed changes

mmahrouss and others added 17 commits January 27, 2026 11:47

[FIX] Check all relational fields during domain validation

076f22b

While validating search domain, for relational fields, i.e. "m2ofield.normalfield", we should check all the symbols m2ofield on the model, not just one, so we set true on get member symbol

[UPG] update typeshed

e9b2445

[IMP] Handle env get item for multiple fn evals

a2658d9

[IMP] Address cargo compiler warnings

3c0781b

[IMP] handle multiple evals for imports

ca9a944

[IMP] add filter_on_tree to follow_ref

71d619d

[IMP] use filter_on_type to handle typing.Self evaluation

3e32d81

[FIX] do not error on SQL data files

bd11873

[FIX] do not exit on missing python command

033f08c

[IMP] refactor odoo step is_model

0839195

[FIX] Avoid crashing on model classes outside a module

3c162fc

Check if class model is in a module, otherwise do not mark it as a model This is to avoid crashing later due to the class not being in a model. The crash to avoid is in `core.model.Model.get_symbols`

[FIX] missing SELF evaluation to search method

81b2a3d

The base model's search method should have an evaluation of EvaluationSymbolPtr::SELF. This used to be the case, but it got lost in a refactor ([1]). [1]: odoo@ca26c3e

[FIX] allow M2OReference on inverse_name

c8c6edf

Before we were checking if inverse_name arg points to a M2O field, but it can also be a Many2oneReference Fixed false positives for OLS03022

[IMP] mark implicit class methods as such

df1e271

__init_subclass__ and __class_getitem__ have a special behavior where they are implicitly classmethods without the decorator This is added here to avoid, for example, wrong diagnostics

[FIX] fix index calculation in get_indexed_arg_in_call

559413b

Fix arg index to account for is on instance if it is true

fda-odoo changed the base branch from release to alpha-references-fda January 28, 2026 10:08

Merge branch 'alpha-references-fda' into feature/references-phase1

3d3c03b

fda-odoo added this to the 1.3.0 milestone Jan 28, 2026

fda-odoo self-assigned this Jan 28, 2026

fda-odoo force-pushed the alpha-references-fda branch 2 times, most recently from a776bf4 to b0ea6b5 Compare February 10, 2026 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Implement Phase 1 of Go To References (#466) #519

[IMP] Implement Phase 1 of Go To References (#466) #519

Uh oh!

MihaiStreames commented Jan 15, 2026

Uh oh!

fda-odoo left a comment •

edited

Loading

Uh oh!

fda-odoo Jan 18, 2026

Uh oh!

fda-odoo Jan 18, 2026

Uh oh!

fda-odoo Jan 18, 2026

Uh oh!

fda-odoo commented Jan 28, 2026

Uh oh!

fda-odoo commented Jan 28, 2026

Uh oh!

MihaiStreames commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		let (analyse_ast_result, _range, _call_expr) = AstUtils::get_symbols(session, file_symbol, file_info, offset as u32);

		if analyse_ast_result.evaluations.is_empty() {

[IMP] Implement Phase 1 of Go To References (#466) #519

Are you sure you want to change the base?

[IMP] Implement Phase 1 of Go To References (#466) #519

Uh oh!

Conversation

MihaiStreames commented Jan 15, 2026

Summary

Future work

Uh oh!

fda-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fda-odoo Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

fda-odoo Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

fda-odoo Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

fda-odoo commented Jan 28, 2026

Uh oh!

fda-odoo commented Jan 28, 2026

Uh oh!

MihaiStreames commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fda-odoo left a comment •

edited

Loading