chore(deps): bump parent, maven-core, cactoos, tojos; manage slf4j-api#156
Open
bibonix wants to merge 8 commits intoobjectionary:masterfrom
Open
chore(deps): bump parent, maven-core, cactoos, tojos; manage slf4j-api#156bibonix wants to merge 8 commits intoobjectionary:masterfrom
bibonix wants to merge 8 commits intoobjectionary:masterfrom
Conversation
- com.jcabi:parent: 0.70.0 -> 0.73.1 - maven-plugin-api/maven-model/maven-core: 3.9.12 -> 3.9.15 - org.cactoos:cactoos: 0.57.0 -> 0.61.0 - com.yegor256:tojos: 0.18.5 -> 0.19.1 - Pin slf4j-api to 2.0.17 in dependencyManagement to satisfy RequireUpperBoundDeps now that the upgraded transitives no longer agree on a single slf4j version.
The mvn (ubuntu-24.04, 11) leg of the matrix failed because cactoos shipped its first Java-17-bytecode release at 0.58.0 (class file major version 61). Java 11 cannot read those classes. 0.57.0 is the latest release that still targets Java 8, so we stay there.
com.jcabi:parent 0.73.1 imports junit-bom 6.0.3, which is Java-17 only (class file major version 61). The mvn (ubuntu-24.04, 11) job in .github/workflows/mvn.yml started failing with "cannot access org.junit.jupiter.api.Test" because Java 11 cannot read those classes. Importing junit-bom 5.14.4 (the latest 5.x) ahead of the parent BOM restores Java 8 bytecode for the JUnit Jupiter artifacts and gets the matrix back to green without dropping Java 11 from CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades a handful of dependencies (and one parent POM) to their latest stable versions, and aligns
slf4j-apiso thatRequireUpperBoundDepskeeps passing after the upgrades.Changes
com.jcabi:parentorg.apache.maven:maven-plugin-apiorg.apache.maven:maven-modelorg.apache.maven:maven-coreorg.cactoos:cactooscom.yegor256:tojosorg.slf4j:slf4j-api(managed)slf4j-apiis added in<dependencyManagement>(not in<dependencies>) because nothing in this module uses it directly — the override is only there to satisfy the upper-bound enforcer whenjcabi-log(2.0.16) and theeo-parser/xnavchain (2.0.17) disagree on a transitive version.What I did not upgrade and why
org.eolang:eo-parseris intentionally left at 0.59.0. Bumping to 0.59.9 / 0.60.0 / 0.61.0 makes three unit tests fail (ItsAngryTest,ItsDefaultTest,TrSodgTest) because the new parser rejects the inlineQQ.io.stdout "..." > @form used in the test sources, and the SODG produced by 0.60.0+ no longer matches the XPath assertions inTrSodgTest. Both look like real EO-grammar / SODG-shape changes that deserve their own dedicated PR with someone who knows the EO side, not a silent test rewrite hidden inside a deps bump.maven-plugin-api/maven-model/maven-core4.0.0-rc-5is still an RC, so I kept them on the latest 3.9.x.maven-plugin-annotations4.0.0-beta-2 andmaven-install-plugin4.0.0-beta-2 are pre-releases — kept on latest stable (3.15.2 and 3.1.4 respectively, which are already current).log4j-core3.0.0-beta3 is pre-release (n/a here, but flagged byversions:display-dependency-updates).Verification
The only test that I could not run locally is
MjSodgIT, which is broken on this machine for an unrelated reason (command -v mvnreturns two lines becausenvminjects a leading line into the output, and the test passes that toMavenInvokeras the executable path). It runs cleanly on a normal CI runner; nothing in this PR touches its plumbing.