bug(#628): yaml + readme

[maxonfjvipon]

Closes: #628
Closes: #624

Summary by CodeRabbit

• Documentation
  • Added Ubuntu 22.04 as a download option alongside Ubuntu 24.04.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Changes include a modification to the GitHub Actions build matrix for binary releases, concatenating two OS labels without a comma separator (creating a malformed entry), and updating README documentation to list both Ubuntu 22.04 and 24.04 download options instead of only 24.04.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow .github/workflows/release-binary.yml	Build matrix OS list modified with missing comma between ubuntu-24.04 and macos-14-large, creating a single concatenated entry that will be misinterpreted. This malformed syntax may cause workflow failures during runner selection.
Documentation README.md	Download section updated to present both Ubuntu 22.04 and Ubuntu 24.04 binary download options instead of only Ubuntu 24.04, addressing availability of builds across multiple Ubuntu versions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The workflow file contains a critical syntax error requiring careful examination, while the README change is straightforward documentation. Reviewers should verify the intended OS matrix configuration and validate the download links work correctly.

Possibly related PRs

• bug(#170): binary for mac os #176: Modifies .github/workflows/release-binary.yml build matrix OS entries; this PR's malformed concatenation may conflict with or relate to prior matrix configuration attempts.
• bug(#181): updated installation section #318: Updates README installation/download paths for Ubuntu and macOS binaries; aligns with this PR's documentation changes to download instructions.

Poem

🐰 A matrix got tangled, commas went missing in flight,
Ubuntu entries multiplied—now downloads show both versions right,
Twenty-two and twenty-four, a hoppy fix for the night! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 4

❌ Failed checks (2 warnings, 2 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR attempts to address issue #628 about incorrect binary download links, but the YAML changes appear to introduce a syntax error that would break the workflow rather than fix the issue.	Verify the YAML syntax in release-binary.yml is correct; the current change appears to concatenate 'ubuntu-24.04 macos-14-large' as a single entry, which would break the build matrix.
Out of Scope Changes check	⚠️ Warning	The YAML file modification appears unrelated to the primary objective of fixing the README's binary download link reference, potentially introducing unintended breaking changes.	Clarify the relationship between the YAML workflow changes and issue #628, or separate the YAML fixes into a distinct PR if they address a different concern.
Title check	❓ Inconclusive	The title 'bug(#628): yaml + readme' is vague and generic, using abbreviations and file names without conveying the actual nature of the bug.	Consider a more descriptive title like 'fix: correct binary release paths in workflow and README for Ubuntu versions' to better communicate the actual changes.
Description check	❓ Inconclusive	The PR provides only a minimal description ('Closes: #628') with no explanation of the changes or how they resolve the reported issue.	Add a detailed description explaining why the YAML and README modifications fix the binary download issue, and clarify the purpose of each change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

[maxonfjvipon]

@rultor merge

[rultor]

@rultor merge

@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here.

[rultor]

@rultor merge

@maxonfjvipon Done! FYI, the full log is here (took me 20min).