Skip to content

fix(#603): update text library version constraint for GHC compatibility#604

Merged
rultor merged 1 commit intoobjectionary:masterfrom
volodya-lombrozo:603-ghc-phino-build-fix
Jan 21, 2026
Merged

fix(#603): update text library version constraint for GHC compatibility#604
rultor merged 1 commit intoobjectionary:masterfrom
volodya-lombrozo:603-ghc-phino-build-fix

Conversation

@volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jan 21, 2026

This PR updates the text library version constraint in phino.cabal to resolve build issues with GHC 9.12.2.

Fixes #603

Summary by CodeRabbit

  • Chores
    • Updated text library dependency constraints to support a broader range of compatible versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Changed the text package version constraint in phino.cabal from a caret range (^>=2.0.2) to an open-ended minimum version (>=2.0.2), removing the implicit upper bound to permit newer text library versions.

Changes

Cohort / File(s) Summary
Dependency Version Constraint
phino.cabal
Updated text package constraint from ^>=2.0.2 to >=2.0.2, removing the upper bound to allow newer versions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A caret once capped our text,
But new GHC versions flexed,
So we widened the range,
Let versions exchange—
Build constraints no longer vexed! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the text library version constraint in phino.cabal to fix GHC 9.12.2 compatibility issues.
Linked Issues check ✅ Passed The code change directly addresses issue #603 by modifying the text dependency constraint from ^>=2.0.2 to >=2.0.2, resolving the GHC 9.12.2 build failure.
Out of Scope Changes check ✅ Passed The pull request contains only the necessary change to the phino.cabal file's text dependency constraint, with no additional unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon could you take a look, please?

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
phino.cabal (1)

170-170: Inconsistent text constraint in test-suite section.

The library section was updated to >=2.0.2, but the test-suite still uses the restrictive ^>=2.0.2 constraint. This could cause the same GHC 9.12.2 build failures when running tests.

Proposed fix
-    text ^>=2.0.2,
+    text >=2.0.2,

@volodya-lombrozo
Copy link
Member Author

@yegor256 could you merge this one, please?

@maxonfjvipon
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 21, 2026

@rultor merge

@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 798d18e into objectionary:master Jan 21, 2026
19 checks passed
@rultor
Copy link
Contributor

rultor commented Jan 21, 2026

@rultor merge

@maxonfjvipon Done! FYI, the full log is here (took me 14min).

@0crat
Copy link

0crat commented Jan 21, 2026

@maxonfjvipon Great work on the review! 🎉 You've earned +4 points (base +12, with adjustments for missing comments and code coverage). Your total score is now +395 - keep up the momentum! Remember to check your Zerocracy account for updates.

@0crat
Copy link

0crat commented Jan 21, 2026

@volodya-lombrozo Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 2 hits-of-code). Your total score is now +201 - excellent progress! Keep delivering quality contributions and don't forget to check your Zerocracy account for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't build phino with the new version of GHC

4 participants