fix(#603): update text library version constraint for GHC compatibility#604
Conversation
📝 WalkthroughWalkthroughChanged the text package version constraint in phino.cabal from a caret range ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@maxonfjvipon could you take a look, please? |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
phino.cabal (1)
170-170: Inconsistenttextconstraint in test-suite section.The library section was updated to
>=2.0.2, but the test-suite still uses the restrictive^>=2.0.2constraint. This could cause the same GHC 9.12.2 build failures when running tests.Proposed fix
- text ^>=2.0.2, + text >=2.0.2,
|
@yegor256 could you merge this one, please? |
|
@rultor merge |
@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here. |
@maxonfjvipon Done! FYI, the full log is here (took me 14min). |
|
@maxonfjvipon Great work on the review! 🎉 You've earned +4 points (base +12, with adjustments for missing comments and code coverage). Your total score is now +395 - keep up the momentum! Remember to check your Zerocracy account for updates. |
|
@volodya-lombrozo Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 2 hits-of-code). Your total score is now +201 - excellent progress! Keep delivering quality contributions and don't forget to check your Zerocracy account for updates. |
This PR updates the
textlibrary version constraint inphino.cabalto resolve build issues with GHC 9.12.2.Fixes #603
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.