Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #42
Changes:
stix2viscore.js. Retainstix2visfor compatibility with what you already have.Notes
Re: the use of requirejs, and the
"nbextensions"stuff - I don't really know what I'm doing there - but what I've got looks like it's working.Possible bug
Take a look at that
handleSelectedinstix2viscore.js- it looks like it is never defined anywhere.Worth discussing
stix2viscore.jsyou will lose your commit history. Possibly better to put the Jupyter stuff in a different file.Testing
I tested that it works as an npm package here:
https://github.com/dwjohnston/stix-vis-test
Follow the instructions there.
Things that need to be done before this PR is merged:
nameFuture improvements: