[RHELC-967] Verify breadcrumbs source_os #1432
Draft
Andrew-ang9 wants to merge 3 commits intooamg:mainfrom
Draft
[RHELC-967] Verify breadcrumbs source_os #1432Andrew-ang9 wants to merge 3 commits intooamg:mainfrom
Andrew-ang9 wants to merge 3 commits intooamg:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
=======================================
Coverage ? 92.21%
=======================================
Files ? 72
Lines ? 5205
Branches ? 902
=======================================
Hits ? 4800
Misses ? 307
Partials ? 98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
* in the _set_activity(), _set_pkg_object(), _set_executed(), _set_nevra(), _set_signature() in all of these functions there is now some extra verification to make sure that the data that needs to be set is actully set
Andrew-ang9
force-pushed
the
source_os_check
branch
from
56244fe to
3270170
Compare
* this is a draft for the unit tests for set_activity set_pkg_object, set_nevra, and set_signature
Member
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you get to the end of the conversion and you go to check the system information in the migration results some of the data isn't actually filled in primarily the source_os isn't set and is still null. This PR adds in a check to see if any of the migration results are set.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant