use go version 1.24#226
Open
jfairchild wants to merge 5 commits intomainfrom
Open
Conversation
tonglil
reviewed
Oct 28, 2025
Comment on lines
+79
to
+80
| webhook: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
| webhook-type: incoming-webhook |
Member
There was a problem hiding this comment.
The current CI is failing with this.
I'm not aware of the updated syntax, but we can give this a try.
Comment on lines
+12
to
+14
| find ${gcloud_sdk_bin_dir} -type f -name ${extra_kubectl_glob} -exec basename {} \; | | ||
| cut -d '.' -f 2,3 | | ||
| sort -g |
| rev = "[unknown]" | ||
| } | ||
|
|
||
| fmt.Printf("Drone GKE Plugin built from %s\n", rev) |
Member
There was a problem hiding this comment.
If I recall, for these messages to render properly in Drone, the newlines are necessary.
| log("Parsing Project ID from credentials") | ||
| project = getProjectFromToken(token) | ||
| if project == "" { | ||
| return fmt.Errorf("Missing required param: project") |
Member
There was a problem hiding this comment.
And same with capitalizing the error message - it's not idiomatic go, but it's used as output in the logs.
Member
There was a problem hiding this comment.
There's valid changes in here that I'll extract out, but will revert the commented on changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is a change to the core functionality, did you make a corresponding PR to drone-eks?
Did you update the tests?
Did you update the docs?