Closed
Conversation
Remove `type` field as is not a field defined in the metadata syntax for github actions. Add description to the action and `root` input parameter. The input parameter is not required as it has a default.
This has been updated to `standards-first-react-alternative` which is the valid subdirectory.
Expand MIME type map in web server to broaden asset type support with fallback (fonts, source maps, etc)
Update legacy introducing-hyper link
To get out of scope changes out of nuejs#556 for a better diff
docs: cleanup
chore(nuekit): formatting
this is for testing only; should probably be removed before a potential merge
frfr no cap, it's better! Nesting and the Nue value inheritance approach don't play well together. If the parent "lit.yaml" has a `collection_name` "bussin", and its child "lame.yaml" has no `collection_name`, the childs title would inherit the "bussin" even it's lame. Cringe, I don't feel it. Path is the right flex here fr.
also dropped the custom `subtitle` (a.k.a. "description") option here, and omitted rendering, because it has the same inheritance problem as described in the previous commit for the title. For now, I believe it's the most sensible thing to just ignore the optional (see spec) `subtitle`. Maybe someone can come up with a GOAT solution later.
everything I said in previous commits can safely be ignored
Contributor
Author
|
I have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #283. This is a follow up to, and based on, #556.
Differences:
subtitle(prev. description),authorhas_feedoption. It works with inerhitance, childs can be (in/ex)cluded on demand.getPageData()Discussion:
has_feed, I don't think adding a--feedflag is neccessary. When do you ever want to deploy without making sure your feed is updated? But your call, @tipiirai. Fwiw, performance lgtm..htmlhas_feedwas changed tofalse. The issue, however, applies to normal files as well, not only feeds.@nobkd I forked your branch and kept your commits so that you don't lose co-authorship.