[Performance] Pruning energy-sorted ensembles#11
Merged
ntampellini merged 3 commits intomasterfrom Nov 9, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
Tried exiting early from rotationally_corrected_rmsd_and_max as soon as a global RMSD value below the desired one is found. That was unfortunately slower, as it increased the number of calls to rmsd_and_max and had a very low success rate in exiting early from the function. Idea scrapped for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If energies are provided (and therefore also a maximum energy difference that structure must have to be considered similar) the ensemble is energy-sorted before pruning, so that energetically similar structures are more likely to be grouped together early and pruned as soon as possible, reducing the total number of evaluate_sim calls.
The ConformerEnseble XYZ reader can now read energies from structures comment lines.