Skip to content

fix(core): nx reset --daemonOnly should also remove d/ dir #34262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxKless wants to merge 1 commit into from
Closed

fix(core): nx reset --daemonOnly should also remove d/ dir #34262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/nx/src/command-line/reset/reset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { rmSync } from 'node:fs';
import { join } from 'node:path';

import { daemonClient } from '../../daemon/client/client';
import { DAEMON_DIR_FOR_CURRENT_WORKSPACE } from '../../daemon/tmp-dir';
import { cacheDir, workspaceDataDirectory } from '../../utils/cache-directory';
import { output } from '../../utils/output';
import { getNativeFileCacheLocation } from '../../native/native-file-cache-location';
Expand Down Expand Up @@ -55,6 +56,11 @@ export async function resetHandler(args: ResetCommandOptions) {
} catch (e) {
errors.push('Failed to stop the Nx Daemon.', e.toString());
}
try {
await cleanupDaemonDir();
} catch (e) {
errors.push('Failed to clean up the daemon directory.', e.toString());
}
}
if (all || args.onlyCache) {
try {
Expand Down Expand Up @@ -105,6 +111,19 @@ async function killDaemon(): Promise<void> {
}
}

function cleanupDaemonDir() {
return incrementalBackoff(
INCREMENTAL_BACKOFF_FIRST_DELAY,
INCREMENTAL_BACKOFF_MAX_DURATION,
() => {
rmSync(DAEMON_DIR_FOR_CURRENT_WORKSPACE, {
recursive: true,
force: true,
});
}
);
}

async function resetCloudClient() {
// Remove nx cloud marker files. This helps if the use happens to run `nx-cloud start-ci-run` or
// similar commands on their local machine.
Expand Down