Skip to content

Enhance readQueryVariable to support boolean, numeric and string values #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mauigna06 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

Enhance readQueryVariable to support boolean, numeric and string values #1966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion vnc_lite.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,22 @@

if (match) {
// We have to decode the URL since want the cleartext value
return decodeURIComponent(match[1]);
const value = decodeURIComponent(match[1]);
if (value.toLowerCase() === 'false' || value === '0') {
return false;
}
if (value.toLowerCase() === 'true' || value === '1') {
return true;
}
Comment on lines +121 to +126
Copy link
Member

@CendioOssman CendioOssman Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work since you don't know if the caller wants a Number or Boolean.

I'd suggest adding a typed wrapper so the caller can be clear what it wants. I.e. readBoolQueryVariable().

// Check for integer
if (/^-?\d+$/.test(value)) {
return parseInt(value, 10);
}
// Check for float
if (/^-?\d*\.\d+$/.test(value)) {
return parseFloat(value);
}
return value;
}

return defaultValue;
Expand Down