fix: callhash from event#57
Open
cuteWarmFrog wants to merge 11 commits intomainfrom
Open
Conversation
stepanLav
reviewed
Aug 28, 2025
valentunn
requested changes
Sep 1, 2025
valentunn
reviewed
Sep 2, 2025
Comment on lines
+30
to
+36
| .on("utility", ["batch", "batchAll", "forceBatch"], (extrinsic, context) => { | ||
| const calls = extrinsic.call.args.at(0); | ||
| if (Array.isArray(calls) && calls.length > 100) { | ||
| // we're skipping large batches, something terrible happens inside anyway | ||
| context.stop(); | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
I wonder whether this can be extracted to some common function somehow since it becomes the common practice - it is used twice here and I also saw Stepan uses the same in his pr. Something like CreateCallVisitorBuilder.stopOnLargeBatches() would be ideal but i am not sure whether ts allows that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.