Force Nova pool for Asset Hub and lock Novasama validators in selection#2268
Open
Leemo94 wants to merge 2 commits intonovasamatech:developfrom
Open
Force Nova pool for Asset Hub and lock Novasama validators in selection#2268Leemo94 wants to merge 2 commits intonovasamatech:developfrom
Leemo94 wants to merge 2 commits intonovasamatech:developfrom
Conversation
Leemo94
commented
Mar 20, 2026
Leemo94
commented
- Bypass pool selection screen for Polkadot/Kusama Asset Hub chains; recommendation system selects Nova pool and user cannot change it
- Pool name hidden on staking type screen; "Recommended" label persists
- Preferred (Nova) validators locked at bottom of custom validator list with greyed-out checkboxes; cannot be deselected via tap, search, edit-mode delete, or "Deselect All"
- Selection count reflects community-only available slots
- Bypass pool selection screen for Polkadot/Kusama Asset Hub chains; recommendation system selects Nova pool and user cannot change it - Pool name hidden on staking type screen; "Recommended" label persists - Preferred (Nova) validators locked at bottom of custom validator list with greyed-out checkboxes; cannot be deselected via tap, search, edit-mode delete, or "Deselect All" - Selection count reflects community-only available slots Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Part of a broader change for how we present staking.
|
This was referenced Mar 20, 2026
- Move FORCED_NOVA_POOL_CHAIN_IDS from top-level val to forcedPoolChainIds property on the KnownNovaPools interface; implement on FixedKnownNovaPools - Inject KnownNovaPools into EditableStakingTypeItemFormatter via SetupStakingTypeModule so the forced-chain check goes through DI instead of directly importing the constant - Use injected knownNovaPools.forcedPoolChainIds in SetupPoolStakingFlowExecutor (dependency was already wired) instead of the top-level constant - Fix import ordering in SetupStakingTypeModule Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
CI failures here seem to be the standard fork-secrets restriction (scaleway/action-scw-secret can't authenticate without the access key, which GitHub doesn't expose to fork PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.