Draft
Conversation
stepanLav
force-pushed
the
feat/adding_instrumentail_tests
branch
from
d911388 to
8d9e55a
Compare
fix order add unique build remove unit tests fix run tests fix build tests remove example test which lead to error temp fix for build remove example instrumental tests adding debug lines fix debug fix path fix build type fix path build debug version fix path run on github action fix balances tests store results in separate repo fix artifacts path fix artifact version fix download path fix path fix path update secrets fix access remove unnecessary checkout update secrets update storing folder update deployment dir
stepanLav
force-pushed
the
feat/move_tests_to_main_repo
branch
from
216aa97 to
07b8301
Compare
stepanLav
force-pushed
the
feat/adding_instrumentail_tests
branch
from
8d9e55a to
3d3f062
Compare
fix TestSigner
stepanLav
force-pushed
the
feat/move_tests_to_main_repo
branch
from
07b8301 to
03f2a0c
Compare
fix TestSigner
stepanLav
force-pushed
the
feat/adding_instrumentail_tests
branch
from
3d3f062 to
30b1f5f
Compare
Comment on lines
+29
to
+33
| def run(): | ||
| os.system('adb wait-for-device') | ||
| p = sp.Popen('adb shell am instrument -w -m -e notClass io.novafoundation.nova.balances.BalancesIntegrationTest -e package io.novafoundation.nova.debug io.novafoundation.nova.debug.test/io.qameta.allure.android.runners.AllureAndroidJUnitRunner', | ||
| shell=True, stdout=sp.PIPE, stderr=sp.PIPE, stdin=sp.PIPE) | ||
| return p.communicate() |
Contributor
There was a problem hiding this comment.
As I see we start only BalancesIntegrationTest. Is it correct?
Contributor
There was a problem hiding this comment.
Why we need to run balances test separately?
Is it because this test is moved to another directory?
| return EthereumKeypairFactory.generate(seed, junctions) | ||
| } | ||
|
|
||
| private inner class TestSigner( |
Contributor
There was a problem hiding this comment.
Nice solution I guess! But let's move inner class to the bottom of its parent
| } | ||
|
|
||
| private inner class TestSigner( | ||
| private val testPayload: (SignerPayloadExtrinsic) -> Unit |
Contributor
There was a problem hiding this comment.
As I see we don't use testPayload from outside, so we can remove this redundant variable
| private val testPayload: (SignerPayloadExtrinsic) -> Unit | ||
| ) : NovaSigner { | ||
|
|
||
| val accountId = ByteArray(32) { 1 } |
Contributor
There was a problem hiding this comment.
It seems we don't use it but to be semantically correct let's provide accountId to the constructor from outside
MehrdadBadriGol
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Still in process]
That PR adds instrumental tests to the PR's workflow