Allow external pin definitions#12
Open
Gouster4 wants to merge 1 commit intonopnop2002:masterfrom
Open
Conversation
Skip builtin pin definitions if they are already defined before including library. Usefull for defining pins in sketch instead of modifiyng library. Also usefull when linking library in submodule, and still needing define pins in project.
Contributor
Author
|
Data pins needs to be defined all, otherwise they are replaced by library. Control pins can be defined independently. If only one pin is defined in sketch, its being respected, rest is used default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip builtin pin definitions if they are already defined before including library.
Usefull for defining pins in sketch instead of modifiyng library. Also usefull when linking library in submodule, and still needing define pins in project.