feat: add codemod for DEP0159 ERR_INVALID_CALLBACK replacement#417
Open
syhstanley wants to merge 2 commits intonodejs:mainfrom
Open
feat: add codemod for DEP0159 ERR_INVALID_CALLBACK replacement#417syhstanley wants to merge 2 commits intonodejs:mainfrom
syhstanley wants to merge 2 commits intonodejs:mainfrom
Conversation
…ement Replace deprecated ERR_INVALID_CALLBACK with ERR_INVALID_ARG_TYPE in string literals. Handles error code comparisons, switch cases, test assertions, and string includes checks. Also deduplicates redundant || conditions that arise after replacement. Closes nodejs#411 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add missing README.md (required per CONTRIBUTING.md) - Add yaml-language-server schema comment to workflow.yaml - Sort include file patterns alphabetically - Rename Js type alias to JS (codebase convention) - Reorder imports alphabetically (Edit, SgRoot) - Tighten deduplication regex: use [\w.[\]"']+ instead of \S+ - Add single-quote test case (file-7.js) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a codemod for DEP0159 — replaces the deprecated
ERR_INVALID_CALLBACKerror code withERR_INVALID_ARG_TYPE.ERR_INVALID_CALLBACKwithERR_INVALID_ARG_TYPEerr.code === "ERR_INVALID_CALLBACK")assert.throwsexpectations,.includes()checks||conditions after replacement (e.g.,a === "X" || a === "X"→a === "X")Test plan
Closes #411
🤖 Generated with Claude Code