Skip to content

migrate away from tls.parseCertString() feat(DEP0076)#414

Open
KevinSailema wants to merge 3 commits intonodejs:mainfrom
KevinSailema:feat/tls-parse-cert-string-406
Open

migrate away from tls.parseCertString() feat(DEP0076)#414
KevinSailema wants to merge 3 commits intonodejs:mainfrom
KevinSailema:feat/tls-parse-cert-string-406

Conversation

@KevinSailema
Copy link
Copy Markdown

I approached this issue by implementing an AST-based codemod focused on safe transformations, edge-case handling, and strict binding preservation.

I used Claude to draft the initial boilerplate for this PR, specifically:

  • The recipe scaffolding (codemod.yaml, workflow.yaml, package.json).
  • The early draft of the transform structure.
  • The initial test fixture skeletons.

I manually implemented, reviewed, and refined the core logic:

  • Final transform behavior and safety rules in src/workflow.ts.
  • Binding cleanup logic to avoid removing imports when non-call references remain.
  • Replacement strategy for cert.subject / cert.issuer vs. generic string parsing.
  • Edge-case test coverage (including preserving bindings on references).
  • Commit structuring into separate logical steps.
  • Local validation (npm run test --workspace @nodejs/tls-parse-cert-string and node --run pre-commit).

Let me know if you want any part tightened further (logic, fixtures, or commit split). I’m happy to adjust.

@AugustinMauroy
Copy link
Copy Markdown
Member

same review as the other pr

@AugustinMauroy AugustinMauroy added awaiting author Reviewer has requested something from the author ⚠️ fully-AI-generated labels Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting author Reviewer has requested something from the author ⚠️ fully-AI-generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants