feat(timers deprecation): introduce #255

AugustinMauroy · 2025-10-30T10:42:38Z

Resolves feat: handle timers deprecation #241
- Resolves DEP0095: timers.enroll() #335
- Resolves DEP0096: timers.unenroll() #336
- Resolves DEP0126: timers.active() #337
- Resolves DEP0127: timers._unrefActive() #338

AugustinMauroy · 2025-10-30T10:43:08Z

I need review on test cases so I can finish/clean the implementation

Copilot

Pull Request Overview

This PR introduces a comprehensive codemod recipe to migrate deprecated Node.js timers APIs to modern timer functions. The codemod replaces timers.enroll(), timers.unenroll(), timers.active(), and timers._unrefActive() with standard setTimeout(), clearTimeout(), and Timer#unref() constructs, addressing Node.js deprecations DEP0095, DEP0096, DEP0126, and DEP0127.

Key changes include:

New utility functions for GCD calculation and indent detection in the codemod-utils package
Five transformation modules that handle different deprecated APIs
Comprehensive test suite covering various import/require patterns
Automated cleanup of unused imports after transformations

Reviewed Changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 107 comments.

Show a summary per file

File	Description
utils/src/math.ts	Implements GCD function to calculate indentation units
utils/src/math.test.ts	Tests for GCD function including edge cases
utils/src/ast-grep/indent.ts	Detects indentation style and retrieves line indentation
utils/src/ast-grep/indent.test.ts	Tests for indentation detection utilities
utils/src/ast-grep/general.ts	Helper functions for AST manipulation
utils/src/ast-grep/general.test.ts	Tests for AST manipulation helpers
recipes/timers-deprecations/src/*.ts	Five transformation modules for each deprecated API
recipes/timers-deprecations/tests/**	Comprehensive test cases for all transformations
recipes/timers-deprecations/workflow.yaml	Workflow configuration for codemod execution
recipes/timers-deprecations/package.json	Package configuration and test scripts
recipes/timers-deprecations/codemod.yaml	Codemod metadata and registry configuration
recipes/timers-deprecations/README.md	Documentation with examples and caveats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utils/src/ast-grep/indent.test.ts

recipes/timers-deprecations/tests/active/expected/active_import-variants.js

recipes/timers-deprecations/tests/unref/expected/unref_import-variants.js

JakobJingleheimer

Thanks for this and sorry it's taken me a quite a while to get to it. It's been a helluva month :(

recipes/timers-deprecations/README.md

JakobJingleheimer · 2025-12-02T19:32:48Z

@AugustinMauroy I tried to review the rest of this, but the browser tab crashes trying to load it (it's big, but I didn't think it was that big). Would it be possible to break this into smaller pieces?

AugustinMauroy · 2025-12-10T10:01:17Z

@AugustinMauroy I tried to review the rest of this, but the browser tab crashes trying to load it (it's big, but I didn't think it was that big). Would it be possible to break this into smaller pieces?

I already do that. I just sub step for each deprecation + cleanup import

JakobJingleheimer

Thanks for this! Smaller PRs though please 🫠

I didn't review all the test files, but the implementation looks good! I don't understand how DEP0095 possibly works, but it has test coverage, so it obviously does 🤪

recipes/timers-deprecations/src/active-to-standard-timer.ts

recipes/timers-deprecations/src/cleanup-imports.ts

recipes/timers-deprecations/src/enroll-to-set-timeout.ts

recipes/timers-deprecations/src/unref-active-to-unref.ts

recipes/timers-deprecations/tests/active/expected/active_import-variants.js

recipes/timers-deprecations/tests/active/expected/destructured.js

recipes/timers-deprecations/tests/active/input/active_import-variants.js

Co-Authored-By: Jacob Smith <[email protected]>

recipes/timers-deprecations/src/active-to-standard-timer.ts

brunocroh · 2026-01-22T20:13:46Z

recipes/timers-deprecations/src/active-to-standard-timer.ts

+		const matches = rootNode.findAll({
+			rule: {
+				any: [
+					{ pattern: `${bindingPath}($RESOURCE)` },
+					{ pattern: `${bindingPath}($RESOURCE, $$$REST)` },
+				],
+			},
+		});
+


What do you think about having just one rule that always returns all arguments, and then we just take the first one, since that’s the only one that matters?

Suggested change

const matches = rootNode.findAll({

rule: {

any: [

{ pattern: `${bindingPath}($RESOURCE)` },

{ pattern: `${bindingPath}($RESOURCE, $$$REST)` },

],

},

});

const args = rootNode.findAll({

rule: {

any: [

{ pattern: `${bindingPath}($$$ARGS)` },

],

},

});

firstArg = args[0]

it's will need to write something like that:

const argsNode = match.field('arguments'); if (!argsNode) continue; const argNodes = argsNode .children() .filter((c) => ![',', '(', ')'].includes(c.kind())); const resourceNode = argNodes.length ? argNodes[0] : null;

Which isn't better

recipes/timers-deprecations/src/cleanup-imports.ts

recipes/timers-deprecations/src/enroll-to-set-timeout.ts

recipes/timers-deprecations/src/unenroll-to-clear-timer.ts

brunocroh · 2026-01-22T21:16:16Z

recipes/timers-deprecations/src/unenroll-to-clear-timer.ts

+					{ pattern: `${bindingPath}($RESOURCE)` },
+					{ pattern: `${bindingPath}($RESOURCE, $$$REST)` },


ditto: What do you think about having just one rule that always returns all arguments, and then we just take the first one, since that’s the only one that matters?

recipes/timers-deprecations/src/unenroll-to-clear-timer.ts

recipes/timers-deprecations/src/unref-active-to-unref.ts

brunocroh · 2026-01-22T21:18:42Z

recipes/timers-deprecations/src/unref-active-to-unref.ts

+					{ pattern: `${bindingPath}($RESOURCE)` },
+					{ pattern: `${bindingPath}($RESOURCE, $$$REST)` },


ditto: What do you think about having just one rule that always returns all arguments, and then we just take the first one, since that’s the only one that matters?

recipes/timers-deprecations/src/unref-active-to-unref.ts

brunocroh · 2026-01-22T21:20:42Z

All the comments I added are minor and probably just nits, so feel free to add whatever you think is relevant.

Awesome work mate!

JakobJingleheimer · 2026-01-22T21:28:59Z

I think we can proceed with this as-is, but I would reaaaaaalllly prefer if this was broken into separate migrations with a wrapper. The OP even highlights that these things are separate:

Resolves feat: handle timers deprecation #241

Resolves DEP0095: timers.enroll() #335

Resolves DEP0096: timers.unenroll() #336

Resolves DEP0126: timers.active() #337

Resolves DEP0127: timers._unrefActive() #338

I think that is literally the structure this should have:

v24 timer deprecations wrapper
- timers.enroll() migration
- timers.unenroll() migration
- timers.active() migration
- timers._unrefActive() migration

AugustinMauroy · 2026-01-22T21:39:03Z

I think we can proceed with this as-is, but I would reaaaaaalllly prefer if this was broken into separate migrations with a wrapper. The OP even highlights that these things are separate:

Resolves feat: handle timers deprecation #241

Resolves DEP0095: timers.enroll() #335

Resolves DEP0096: timers.unenroll() #336

Resolves DEP0126: timers.active() #337

Resolves DEP0127: timers._unrefActive() #338

I think that is literally the structure this should have:

v24 timer deprecations wrapper

timers.enroll() migration

timers.unenroll() migration

timers.active() migration

timers._unrefActive() migration

I think you had right ... But I'm lazy I dunno how to name theses codemod.

What do we Win to split codemod into small codemod since we use steps ?

Co-Authored-By: Bruno Rodrigues <[email protected]>

JakobJingleheimer · 2026-01-22T21:43:30Z

But I'm lazy

Fair. Me too

how to name theses codemod

What it says on the tin: timers-enroll-to-… etc

What do we Win to split codemod into small codemod since we use steps?

Users may not need or want to migrate AllTheThings. They may want to migrate just a subset. If they want AllTheThings, run the wrapper; if just A, B, C, run A, B, C.

It also makes the PR more digestable. It's currently 1.75K LoC 😱

AugustinMauroy · 2026-01-22T21:47:32Z

Users may not need or want to migrate AllTheThings. They may want to migrate just a subset. If they want AllTheThings, run the wrapper; if just A, B, C, run A, B, C.

Oh make sense !

It also makes the PR more digestable. It's currently 1.75K LoC 😱

In future I will not do that again sorry 😅 but this time if I split into multiple pr it's will take more time to ship.
and if I modify this pr to use multiple codemod it's will increase the amount of code

JakobJingleheimer · 2026-01-22T21:51:15Z

if I split into multiple pr it's will take more time to ship

Yes 😥 I think I'll have a couple hours this weekend to help.

if I modify this pr to use multiple codemod it's will increase the amount of code

I think only slightly. If there is commonality, hoist it into a helper within the wrapper and share it 🙂

AugustinMauroy · 2026-01-22T21:57:07Z

Yes 😥 I think I'll have a couple hours this weekend to help.

If you can do it. But me I'm going to be off so the only action that I will be able to do is to approve pr.

JakobJingleheimer · 2026-01-22T22:07:58Z

I'm away for a week starting Tuesday.

Btw we could also suppose there is a really bad bug in one of these. If they're all together, users can't use any of them; but if they're separate, users who need any of the 3 without the hypothetical bug can use them just fine instead of being stuck.

AugustinMauroy added 4 commits October 29, 2025 22:43

feat(timers-deprecations): scaffould

d81e531

update

7409e1b

Update cleanup-imports.ts

b679ff5

update and add more case

a88c1c4

AugustinMauroy mentioned this pull request Oct 30, 2025

spec(v22-to-v24): what we have to do #239

Open

18 tasks

AugustinMauroy added 3 commits October 31, 2025 14:35

fix: support of windows

b5635b5

split utility

bfc9b18

Merge branch 'main' into augustin/timers-deprecation

c3b4d51

AugustinMauroy requested review from a team and Copilot October 31, 2025 14:09

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer dep:v24 Migration handles deprecation introduced in node v24 dep:EoL Migration handles deprecation introduced in an EoL version of node labels Oct 31, 2025

Copilot AI reviewed Oct 31, 2025

View reviewed changes

AugustinMauroy linked an issue Nov 1, 2025 that may be closed by this pull request

feat: handle timers deprecation #241

Open

JakobJingleheimer reviewed Dec 1, 2025

View reviewed changes

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

doc: use diff

3292eac

AugustinMauroy requested a review from a team December 15, 2025 19:32

JakobJingleheimer approved these changes Dec 31, 2025

View reviewed changes

JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Jan 1, 2026

AugustinMauroy added the awaiting author Reviewer has requested something from the author label Jan 9, 2026

AugustinMauroy and others added 4 commits January 17, 2026 17:08

update

d4b29f8

Co-Authored-By: Jacob Smith <[email protected]>

Merge branch 'main' into augustin/timers-deprecation

6b56cc0

Update package-lock.json

d148c73

Update package-lock.json

7d3e420

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 17, 2026

brunocroh reviewed Jan 22, 2026

View reviewed changes

recipes/timers-deprecations/src/cleanup-imports.ts Outdated Show resolved Hide resolved

recipes/timers-deprecations/src/cleanup-imports.ts Show resolved Hide resolved

recipes/timers-deprecations/src/cleanup-imports.ts Outdated Show resolved Hide resolved

Merge branch 'main' into augustin/timers-deprecation

71840fb

brunocroh approved these changes Jan 22, 2026

View reviewed changes

Update

9321583

Co-Authored-By: Bruno Rodrigues <[email protected]>

		{ pattern: `${bindingPath}($RESOURCE)` },
		{ pattern: `${bindingPath}($RESOURCE, $$$REST)` },

Uh oh!

feat(timers deprecation): introduce #255

Are you sure you want to change the base?

feat(timers deprecation): introduce #255

Conversation

AugustinMauroy commented Oct 30, 2025 • edited by JakobJingleheimer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy commented Oct 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer commented Dec 2, 2025

Uh oh!

AugustinMauroy commented Dec 10, 2025

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brunocroh Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brunocroh Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brunocroh Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brunocroh commented Jan 22, 2026

Uh oh!

JakobJingleheimer commented Jan 22, 2026

Uh oh!

AugustinMauroy commented Jan 22, 2026

Uh oh!

AugustinMauroy commented Oct 30, 2025 •

edited by JakobJingleheimer

Loading

JakobJingleheimer left a comment •

edited

Loading