Fix: Create a request cache to ensure that each credential is only fetched once#966
Open
erbenjak wants to merge 10 commits intorelease/openid4vcfrom
Open
Fix: Create a request cache to ensure that each credential is only fetched once#966erbenjak wants to merge 10 commits intorelease/openid4vcfrom
erbenjak wants to merge 10 commits intorelease/openid4vcfrom
Conversation
…ame-credential-offer-url
There was a problem hiding this comment.
Pull request overview
This PR implements an in-memory cache for credential offer requests to prevent duplicate API calls when the same credential offer URL appears multiple times in a single request expansion. The cache stores Promises to ensure concurrent calls for the same URL share the same underlying request, addressing a race condition in the existing persistent cache implementation.
Changes:
- Added an in-memory Promise-based cache (
credentialOfferCache) to theDataViewExpanderclass - Modified credential offer request handling to check the cache before making new requests
- Wrapped the API call in error handling that returns
undefinedon failure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…' of github.com:nmshd/runtime into bug/duplicate-requests-on-the-same-credential-offer-url
…ame-credential-offer-url
…ame-credential-offer-url
…' of github.com:nmshd/runtime into bug/duplicate-requests-on-the-same-credential-offer-url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist