lib/utils: init addSubOptions#4050
Draft
MattSturgeon wants to merge 1 commit intonix-community:mainfrom
Draft
Conversation
Adds `addSubOptions` and `addSubOptionsWith` util functions to extend an option-type with docs-only sub-options. These functions use a similar interface to `types.submodule` and `types.submoduleWith` to extend an existing option-type with additional docs sub-options, returned by `getSubOptions`. The sub-options do not affect the normal operation of the type, such as checking or merging definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes two new utility functions,
addSubOptionsandaddSubOptionsWith, which allow a base option-type (e.g.luaTypes.anything) to be extended with documentation-only sub-options. These are primarily intended for Nixvim’ssettingsoptions and similar cases where sub-options need to be documented without affecting evaluation.Motivation
configand led to the introduction of “null and empty” culling intoLuaObject.addSubOptionsallows modules to document sub-options without introducing any runtime config values.settings, and ultimately remove “null and empty” culling fromtoLuaObject.Design and Implementation
The interface mirrors
types.submodule/types.submoduleWith:addSubOptions type module→ extends a base type with docs-only sub-options.addSubOptionsWith { type, modules, ... }→ supportsspecialArgsandclass, matchingtypes.submoduleWith.Key behaviour:
getSubOptions.Intended Use Cases
Documenting
settingssub-options, for example:Any scenario where we want rich, structured sub-option documentation without runtime side effects.
Limitations
mkRenameOptionModulemay fail when renaming to a sub-attribute.functor.Next Steps
This PR is currently a draft, pending an adoption target.
submoduletoaddSubOptions.Once submodules are fully replaced:
toLuaObjectcan be removed.pkgs.formats.luaandlib.generators.toLua.