Skip to content

Conversation

@hobu
Copy link
Contributor

@hobu hobu commented Aug 14, 2025

This fixes #43 by installing the SPZ headers into ${CMAKE_INSTALL_INCLUDEDIR}/spz

@ProjitB
Copy link
Collaborator

ProjitB commented Aug 20, 2025

I guess a slight concern here is that others using the build system may need to change their paths?

@hobu
Copy link
Contributor Author

hobu commented Aug 20, 2025

yes, this could result in software having to change its include paths or explicitly adding ${CMAKE_INSTALL_INCLUDEDIR}/spz as an include path when people are compiling existing code.

@ProjitB
Copy link
Collaborator

ProjitB commented Aug 23, 2025

I still like the idea of doing this. Just thinking whether bumping our minor version would sufficient if we take in this change.

@hobu
Copy link
Contributor Author

hobu commented Aug 23, 2025

Just thinking whether bumping our minor version would sufficient if we take in this change.

IMO this change should happen in a major version release.

Speaking of which, I think it would be a good idea to add both library version and format version information.

@ProjitB
Copy link
Collaborator

ProjitB commented Sep 3, 2025

Yeah we're still figuring out how to cleanly separate those (or at least the messaging of it). For now I'm going to add a label to this to target it for a v3.0.0 library release.

@ProjitB ProjitB added the v3.0.0 PRs to be merged with v3.0.0 library release. label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0.0 PRs to be merged with v3.0.0 library release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPZ pollutes include root installation path

2 participants