Conversation
|
Warning Rate limit exceeded@nh13 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
…n calculation - Clamp distance `d` to valid range [min_dist, l] where min_dist = read1_len + read2_len - Use 64-bit arithmetic for range calculation to prevent overflow - Skip iteration if calculated range is invalid This fixes issues where extreme values from the normal distribution could cause: 1. Negative distance values leading to incorrect position calculations 2. Integer overflow in (l - d + 1) expression Closes #96 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
88ea032 to
bee7150
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
dto valid range to prevent negative/invalid values from normal distributionCloses #96
Root Cause
When generating paired-end reads, the distance
dis calculated from a normal distribution. With extreme values (e.g., -10 sigma),dcan become negative, causing:(l - d + 1)to overflowChanges
Both occurrences in
dwgsim_core()are fixed:Test plan
make test-integration)🤖 Generated with Claude Code