Skip to content

Lossen repository validation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barryvdh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lossen repository validation #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da228d
Lossen repository validation
barryvdh Sep 25, 2016
6d63cc5
Remove test
barryvdh Sep 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Services/Form/Project/ProjectFormLaravelValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ProjectFormLaravelValidator extends AbstractLaravelValidator
'stage' => 'required',
'recipe_id' => 'required',
'server_id' => 'required|exists:servers,id',
'repository' => 'required|url',
'repository' => 'required',
'deploy_path' => 'string',
'email_notification_recipient' => 'email',
'days_to_keep_deployments' => 'integer|min:1',
Expand Down
31 changes: 0 additions & 31 deletions tests/Services/Form/Project/ProjectFormLaravelValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,37 +115,6 @@ public function test_Should_FailToValidate_When_RepositoryFieldIsMissing()
$this->assertInstanceOf('Illuminate\Support\MessageBag', $errors);
}

public function test_Should_FailToValidate_When_RepositoryFieldIsInvalidUrl()
{
Factory::create('App\Models\Recipe', [
'name' => 'Recipe 1',
'description' => '',
'body' => '',
]);

Factory::create('App\Models\Server', [
'name' => 'Server 1',
'description' => '',
'body' => '',
]);

$input = [
'name' => 'Project 1',
'recipe_id' => [1],
'server_id' => 1,
'repository' => 'invalid_url',
'stage' => 'staging',
];

$form = new ProjectFormLaravelValidator($this->app['validator']);

$result = $form->with($input)->passes();
$errors = $form->errors();

$this->assertFalse($result, 'Expected validation to fail.');
$this->assertInstanceOf('Illuminate\Support\MessageBag', $errors);
}

public function test_Should_FailToValidate_When_StageFieldIsMissing()
{
Factory::create('App\Models\Recipe', [
Expand Down