Skip to content

Conversation

@TCLamnidis
Copy link
Contributor

@TCLamnidis TCLamnidis commented Jan 21, 2026

This updates the containers used by gatk3 to sequera wave containers. The mulled biocontainer was having problems running on the GH runner.
See https://github.com/nf-core/eager/actions/runs/21064061754/job/60577190179?pr=1164

Adding versions to topic at the moment would create a host of additional work for me at nf-core eager template merge, so I will not do this yet. I intend to do this in a separate PR.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • Broadcast software version numbers to topic: versions - See version_topics
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@TCLamnidis TCLamnidis marked this pull request as draft January 21, 2026 16:29
@TCLamnidis TCLamnidis marked this pull request as ready for review January 21, 2026 16:48
@TCLamnidis TCLamnidis requested a review from jfy133 January 21, 2026 16:48
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the HTTPS link for Singularity container (check box on the container link modal)

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can emerge once tests pass!

@jfy133 jfy133 added this pull request to the merge queue Jan 21, 2026
Merged via the queue into master with commit 91e64b8 Jan 21, 2026
22 checks passed
@jfy133 jfy133 deleted the gatk_update branch January 21, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants