Skip to content

feat(samtools/view): add -L option for BED file filtering#11042

Open
luisas wants to merge 3 commits intonf-core:masterfrom
luisas:samtools-view-add-L-option
Open

feat(samtools/view): add -L option for BED file filtering#11042
luisas wants to merge 3 commits intonf-core:masterfrom
luisas:samtools-view-add-L-option

Conversation

@luisas
Copy link
Contributor

@luisas luisas commented Mar 25, 2026

Add optional 'bed' input channel to SAMTOOLS_VIEW process to support filtering alignments by genomic region using the samtools -L flag.

Changes:

  • main.nf: add 'path bed' input, 'def bedfile' variable, and ${bedfile} in command
  • meta.yml: document new 'bed' input with EDAM ontology
  • tests/main.nf.test: shift index_format from input[3] to input[4] in all existing tests (insert input[3] = [] for bed), and add new bam_with_bed test

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

luisas added 3 commits March 25, 2026 11:25
Add optional 'bed' input channel to SAMTOOLS_VIEW process to support
filtering alignments by genomic region using the samtools -L flag.

Changes:
- main.nf: add 'path bed' input, 'def bedfile' variable, and ${bedfile} in command
- meta.yml: document new 'bed' input with EDAM ontology
- tests/main.nf.test: shift index_format from input[3] to input[4] in all
  existing tests (insert input[3] = [] for bed), and add new bam_with_bed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant